Changed install scripts so they don't have hardcoded values

Dan
(This used to be commit 2eccc5eea289fa4b6af120d0bc92d568ca925482)

1 files changed, 25 insertions, 8 deletions

diff --git a/source3/script/installscripts.sh b/source3/script/installscripts.sh
index c27d41c36b..ab9035ff81 100755
--- a/source3/script/installscripts.sh
+++ b/source3/script/installscripts.sh
@@ -1,26 +1,43 @@
 #!/bin/sh
 # this script courtesy of James_K._Foote.PARC@xerox.com
+# 5 July 96 Dan.Shearer@UniSA.Edu.Au  Don't hardcode script names, get from Make
+
 INSTALLPERMS=$1
 BINDIR=$2
-SRCDIR=$3
+
+shift
+shift
 
 echo Installing scripts in $BINDIR
 
-for d in $BINDIR; do
+for d in [ $BINDIR ]; do
  if [ ! -d $d ]; then
   mkdir $d
   if [ ! -d $d ]; then
     echo Failed to make directory $d
+    echo Have you run installbin first?
     exit 1
   fi
  fi
 done
 
-cp ${SRCDIR}smbtar $BINDIR
-cp ${SRCDIR}addtosmbpass $BINDIR
-echo Setting permissions on scripts
-chmod $INSTALLPERMS $BINDIR/smbtar
-chmod $INSTALLPERMS $BINDIR/addtosmbpass
+for p in $*; do
+  echo Installing $BINDIR/$p
+  cp $p $BINDIR/$p
+  if [ ! -f $BINDIR/$p ]; then
+    echo Cannot copy $p... does $USER have privileges?
+  fi
+  echo Setting permissions on $BINDIR/$p
+  chmod $INSTALLPERMS $BINDIR/$p
+done
+
+cat << EOF
+======================================================================
+The scripts have been installed. You may uninstall them using
+the command "make uninstallscripts" or "make install" to install binaries,
+man pages and shell scripts. You may recover the previous version (if any
+by "make revert".
+======================================================================
+EOF
 
-echo Scripts installed
 exit 0