diff options
| author | Volker Lendecke <vl@samba.org> | 2008-04-02 15:54:49 +0200 |
|---|---|---|
| committer | Volker Lendecke <vl@samba.org> | 2008-04-14 13:13:46 +0200 |
| commit | a4c0812af0132476dfd542ca212304de898fa7c7 (patch) | |
| tree | b3ba22b12fef8616ef11c096d2ffddd3064d4f29 /source3/smbd/lanman.c | |
| parent | 394150d2692ff1249d0945f719202fdf287ff42e (diff) | |
| download | samba-a4c0812af0132476dfd542ca212304de898fa7c7.tar.gz samba-a4c0812af0132476dfd542ca212304de898fa7c7.tar.bz2 samba-a4c0812af0132476dfd542ca212304de898fa7c7.zip | |
Fix some "ignoring asprintf result" warnings
(This used to be commit 155d62ddfd3584d44a493c2aa1ea7f096bcff432)
Diffstat (limited to 'source3/smbd/lanman.c')
| -rw-r--r-- | source3/smbd/lanman.c | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/source3/smbd/lanman.c b/source3/smbd/lanman.c index 18e6bf9f7b..6fa4f9698d 100644 --- a/source3/smbd/lanman.c +++ b/source3/smbd/lanman.c @@ -1971,24 +1971,24 @@ static bool api_RNetShareAdd(connection_struct *conn,uint16 vuid, return False; } - asprintf(&command, "%s \"%s\" \"%s\" \"%s\" \"%s\"", - lp_add_share_cmd(), get_dyn_CONFIGFILE(), sharename, pathname, comment); + if (asprintf(&command, "%s \"%s\" \"%s\" \"%s\" \"%s\"", + lp_add_share_cmd(), get_dyn_CONFIGFILE(), sharename, + pathname, comment) == -1) { + return false; + } - if (command) { - DEBUG(10,("api_RNetShareAdd: Running [%s]\n", command )); + DEBUG(10,("api_RNetShareAdd: Running [%s]\n", command )); - if ((res = smbrun(command, NULL)) != 0) { - DEBUG(1,("api_RNetShareAdd: Running [%s] returned (%d)\n", command, res )); - SAFE_FREE(command); - res = ERRnoaccess; - goto error_exit; - } else { - SAFE_FREE(command); - message_send_all(smbd_messaging_context(), - MSG_SMB_CONF_UPDATED, NULL, 0, NULL); - } + if ((res = smbrun(command, NULL)) != 0) { + DEBUG(1,("api_RNetShareAdd: Running [%s] returned (%d)\n", + command, res )); + SAFE_FREE(command); + res = ERRnoaccess; + goto error_exit; } else { - return False; + SAFE_FREE(command); + message_send_all(smbd_messaging_context(), + MSG_SMB_CONF_UPDATED, NULL, 0, NULL); } *rparam_len = 6; |