diff options
| author | Jeremy Allison <jra@samba.org> | 2009-11-17 14:55:02 -0800 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2009-11-17 14:55:02 -0800 |
| commit | a770caed0ff66ddc2d63ac83d20f4cd7fcc2caf5 (patch) | |
| tree | 479bcb278bcd0ccd20f9506c976d47cb6f41e356 /source3/smbd/nttrans.c | |
| parent | a31838eb3c40f4b70c629f94620f435214e414d4 (diff) | |
| download | samba-a770caed0ff66ddc2d63ac83d20f4cd7fcc2caf5.tar.gz samba-a770caed0ff66ddc2d63ac83d20f4cd7fcc2caf5.tar.bz2 samba-a770caed0ff66ddc2d63ac83d20f4cd7fcc2caf5.zip | |
Remove "store create time" code, cause create time to be stored
in the "user.DOSATTRIB" EA. From the docs:
In Samba 3.5.0 and above the "user.DOSATTRIB" extended attribute has been extended to store
the create time for a file as well as the DOS attributes. This is done in a backwards compatible
way so files created by Samba 3.5.0 and above can still have the DOS attribute read from this
extended attribute by earlier versions of Samba, but they will not be able to read the create
time stored there. Storing the create time separately from the normal filesystem meta-data
allows Samba to faithfully reproduce NTFS semantics on top of a POSIX filesystem.
Passes make test but will need more testing.
Jeremy.
Diffstat (limited to 'source3/smbd/nttrans.c')
| -rw-r--r-- | source3/smbd/nttrans.c | 18 |
1 files changed, 10 insertions, 8 deletions
diff --git a/source3/smbd/nttrans.c b/source3/smbd/nttrans.c index 66102fa96c..bacb9cb0b2 100644 --- a/source3/smbd/nttrans.c +++ b/source3/smbd/nttrans.c @@ -554,10 +554,6 @@ void reply_ntcreate_and_X(struct smb_request *req) } file_len = smb_fname->st.st_ex_size; - fattr = dos_mode(conn, smb_fname); - if (fattr == 0) { - fattr = FILE_ATTRIBUTE_NORMAL; - } if (flags & EXTENDED_RESPONSE_REQUIRED) { /* This is very strange. We @@ -586,6 +582,11 @@ void reply_ntcreate_and_X(struct smb_request *req) } p += 4; + fattr = dos_mode(conn, smb_fname); + if (fattr == 0) { + fattr = FILE_ATTRIBUTE_NORMAL; + } + /* Deal with other possible opens having a modified write time. JRA. */ ZERO_STRUCT(write_time_ts); @@ -1070,10 +1071,6 @@ static void call_nt_transact_create(connection_struct *conn, } file_len = smb_fname->st.st_ex_size; - fattr = dos_mode(conn, smb_fname); - if (fattr == 0) { - fattr = FILE_ATTRIBUTE_NORMAL; - } /* Realloc the size of parameters and data we will return */ if (flags & EXTENDED_RESPONSE_REQUIRED) { @@ -1102,6 +1099,11 @@ static void call_nt_transact_create(connection_struct *conn, } p += 8; + fattr = dos_mode(conn, smb_fname); + if (fattr == 0) { + fattr = FILE_ATTRIBUTE_NORMAL; + } + /* Deal with other possible opens having a modified write time. JRA. */ ZERO_STRUCT(write_time_ts); |