diff options
| author | Volker Lendecke <vlendec@samba.org> | 2006-05-13 23:05:53 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 11:17:02 -0500 |
| commit | ee7b4b47cb590dc16ebdf3a40b360b0f0600aa84 (patch) | |
| tree | 26795be8fbe7f490df678823961c134269d49249 /source3/smbd/password.c | |
| parent | 3895a5a1fcb2c949647fd310b21476aa1db377f2 (diff) | |
| download | samba-ee7b4b47cb590dc16ebdf3a40b360b0f0600aa84.tar.gz samba-ee7b4b47cb590dc16ebdf3a40b360b0f0600aa84.tar.bz2 samba-ee7b4b47cb590dc16ebdf3a40b360b0f0600aa84.zip | |
r15589: While trying to understand the vuid code I found that security=share is broken
right now. r14112 broke it, in 3.0.22 register_vuid for security=share returns
UID_FIELD_INVALID which in current 3_0 is turned into an error condition. This
makes sure that we only call register_vuid if sec!=share and meanwhile also
fixes a little memleak.
Then I also found a crash in smbclient with sec=share and hostmsdfs=yes.
There's another crash with sec=share when coming from w2k3, but I need sleep
now.
Someone (jerry,jra?) please review the sesssetup.c change.
Thanks,
Volker
(This used to be commit 8059d0ae395604503cad3d9f197928305923e3f5)
Diffstat (limited to 'source3/smbd/password.c')
| -rw-r--r-- | source3/smbd/password.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/source3/smbd/password.c b/source3/smbd/password.c index 230d7f297f..73b0ebb4b3 100644 --- a/source3/smbd/password.c +++ b/source3/smbd/password.c @@ -155,10 +155,9 @@ int register_vuid(auth_serversupplied_info *server_info, { user_struct *vuser = NULL; - /* Ensure no vuid gets registered in share level security. */ + /* Paranoia check. */ if(lp_security() == SEC_SHARE) { - data_blob_free(&session_key); - return UID_FIELD_INVALID; + smb_panic("Tried to register uid in security=share\n"); } /* Limit allowed vuids to 16bits - VUID_OFFSET. */ |