got rid of the Files[] array completely (previously I'd just made it

private to files.c)

It now is a doubly linked list with a bitmap for allocated file
numbers. Similarly for the fd_ptr code. I also changed the default
maximum number of open files to 4096. The static cost is 1 bit per
file.

It all seems to work, and it passes the "does Sue scream" test, but if
you see weird behaviour then please investigate. With the volume of
new code that has gone in there are bound to be one or two bugs
lurking.

note that you must do a "make clean" before building this as many data
structures have changed in size.
(This used to be commit 79755ce97004b787d7e83a8d18fc4c7c003b7231)

1 files changed, 2 insertions, 2 deletions

diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c
index 340602d3a5..e62c0bd576 100644
--- a/source3/smbd/reply.c
+++ b/source3/smbd/reply.c
@@ -3279,7 +3279,7 @@ static BOOL copy_file(char *src,char *dest1,connection_struct *conn, int ofun,
 		   1,0,0,&Access,&action);
 
   if (!fsp1->open) {
-	  fsp1->reserved = False;
+	  file_free(fsp1);
 	  return(False);
   }
 
@@ -3296,7 +3296,7 @@ static BOOL copy_file(char *src,char *dest1,connection_struct *conn, int ofun,
 
   if (!fsp2->open) {
     close_file(fsp1,False);
-    fsp2->reserved = False;
+    file_free(fsp2);
     return(False);
   }