summaryrefslogtreecommitdiff
path: root/source3/smbd
diff options
context:
space:
mode:
authorVolker Lendecke <vlendec@samba.org>2003-08-15 01:46:09 +0000
committerVolker Lendecke <vlendec@samba.org>2003-08-15 01:46:09 +0000
commitc9aa836204eb722890cbd4d64248ff7ef1a50e60 (patch)
tree376adbceb833f8a7c59fb05321f6055ac4bee6d2 /source3/smbd
parent062f89bc2833bf49f873a7fd5c2624babd702db0 (diff)
downloadsamba-c9aa836204eb722890cbd4d64248ff7ef1a50e60.tar.gz
samba-c9aa836204eb722890cbd4d64248ff7ef1a50e60.tar.bz2
samba-c9aa836204eb722890cbd4d64248ff7ef1a50e60.zip
Fix memleaks.
Currently I'm compiling against MIT Kerberos 1.2.8. Anthony, you said you have a heimdal installation available. Could you please compile this stuff with krb and check it with valgrind? Thanks, Volker (This used to be commit d8ab44685994b302bb46eed9001c72c194d13dc8)
Diffstat (limited to 'source3/smbd')
-rw-r--r--source3/smbd/sesssetup.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/source3/smbd/sesssetup.c b/source3/smbd/sesssetup.c
index 0b3d42302a..1435c38c99 100644
--- a/source3/smbd/sesssetup.c
+++ b/source3/smbd/sesssetup.c
@@ -171,6 +171,7 @@ static int reply_spnego_kerberos(connection_struct *conn,
}
data_blob_free(&auth_data);
+ data_blob_free(&ticket);
DEBUG(3,("Ticket name is [%s]\n", client));
@@ -178,6 +179,7 @@ static int reply_spnego_kerberos(connection_struct *conn,
if (!p) {
DEBUG(3,("Doesn't look like a valid principal\n"));
data_blob_free(&ap_rep);
+ SAFE_FREE(client);
return ERROR_NT(NT_STATUS_LOGON_FAILURE);
}
@@ -186,6 +188,7 @@ static int reply_spnego_kerberos(connection_struct *conn,
DEBUG(3,("Ticket for foreign realm %s@%s\n", client, p+1));
if (!lp_allow_trusted_domains()) {
data_blob_free(&ap_rep);
+ SAFE_FREE(client);
return ERROR_NT(NT_STATUS_LOGON_FAILURE);
}
foreign = True;
@@ -202,6 +205,8 @@ static int reply_spnego_kerberos(connection_struct *conn,
user = smb_xstrdup(client);
}
+ SAFE_FREE(client);
+
/* setup the string used by %U */
sub_set_smb_name(user);