diff options
| author | Volker Lendecke <vlendec@samba.org> | 2006-06-19 19:07:39 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 11:18:48 -0500 |
| commit | e7fc37cf0f4bd2c0f25865fb07d1bff27b239130 (patch) | |
| tree | 05321a37f1ad2b6082ee1f84beeb1fbe589fe519 /source3/utils/net_rpc_samsync.c | |
| parent | 5c822ecc495bbac95704378c6e09885255076cbe (diff) | |
| download | samba-e7fc37cf0f4bd2c0f25865fb07d1bff27b239130.tar.gz samba-e7fc37cf0f4bd2c0f25865fb07d1bff27b239130.tar.bz2 samba-e7fc37cf0f4bd2c0f25865fb07d1bff27b239130.zip | |
r16360: Fix Klocwork ID 136 520 521 522 523 542 574 575 576 607
in net_rpc.c: 715 716 732 734 735 736 737 738 739 749
in net_rpc_audit.c: 754 755 756
in net_rpc_join.c: 757
in net_rpc_registry: 766 767
in net_rpc_samsync.c: 771 773
in net_sam.c: 797 798
Volker
(This used to be commit 3df0bf7d6050fd7c9ace72487d4f74d92e30a584)
Diffstat (limited to 'source3/utils/net_rpc_samsync.c')
| -rw-r--r-- | source3/utils/net_rpc_samsync.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/source3/utils/net_rpc_samsync.c b/source3/utils/net_rpc_samsync.c index ef9a0627b5..85b086a02f 100644 --- a/source3/utils/net_rpc_samsync.c +++ b/source3/utils/net_rpc_samsync.c @@ -574,6 +574,10 @@ static NTSTATUS fetch_account_info(uint32 rid, SAM_ACCOUNT_INFO *delta) } } + if (pdb_get_group_sid(sam_account) == NULL) { + return NT_STATUS_UNSUCCESSFUL; + } + group_sid = *pdb_get_group_sid(sam_account); if (!pdb_getgrsid(&map, group_sid)) { @@ -694,7 +698,11 @@ static NTSTATUS fetch_group_mem_info(uint32 rid, SAM_GROUP_MEM_INFO *delta) return NT_STATUS_NO_MEMORY; } - nt_members = TALLOC_ZERO_ARRAY(t, char *, delta->num_members); + if ((nt_members = TALLOC_ZERO_ARRAY(t, char *, delta->num_members)) == NULL) { + DEBUG(0, ("talloc failed\n")); + talloc_free(t); + return NT_STATUS_NO_MEMORY; + } for (i=0; i<delta->num_members; i++) { struct samu *member = NULL; |