summaryrefslogtreecommitdiff
path: root/source3/utils
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2007-11-08 17:25:45 -0800
committerJeremy Allison <jra@samba.org>2007-11-08 17:25:45 -0800
commitd40e47db4b5da41c8604a2058f3a0b0a82164f08 (patch)
tree1974bfa70d7b527714b8c68c40e33f2b88efb9e1 /source3/utils
parent976b0ec487720982e456f8c3634be3df64882dae (diff)
downloadsamba-d40e47db4b5da41c8604a2058f3a0b0a82164f08.tar.gz
samba-d40e47db4b5da41c8604a2058f3a0b0a82164f08.tar.bz2
samba-d40e47db4b5da41c8604a2058f3a0b0a82164f08.zip
Remove more fstring/pstring bad useage. Go talloc !
Jeremy. (This used to be commit 2a0173743d2cf615d52278f3dd87cc804abe2d16)
Diffstat (limited to 'source3/utils')
-rw-r--r--source3/utils/net_rpc_printer.c14
1 files changed, 9 insertions, 5 deletions
diff --git a/source3/utils/net_rpc_printer.c b/source3/utils/net_rpc_printer.c
index d14caad975..5e85bae7ee 100644
--- a/source3/utils/net_rpc_printer.c
+++ b/source3/utils/net_rpc_printer.c
@@ -2070,7 +2070,7 @@ NTSTATUS rpc_printer_migrate_settings_internals(const DOM_SID *domain_sid,
REGVAL_CTR *reg_ctr;
struct cli_state *cli_dst = NULL;
char *devicename = NULL, *unc_name = NULL, *url = NULL;
- fstring longname;
+ const char *longname;
uint16 *keylist = NULL, *curkey;
@@ -2094,12 +2094,16 @@ NTSTATUS rpc_printer_migrate_settings_internals(const DOM_SID *domain_sid,
printf ("no printers found on server.\n");
nt_status = NT_STATUS_OK;
goto done;
- }
-
+ }
+
/* needed for dns-strings in regkeys */
- get_mydnsfullname(longname);
-
+ longname = get_mydnsfullname();
+ if (!longname) {
+ nt_status = NT_STATUS_UNSUCCESSFUL;
+ goto done;
+ }
+
/* do something for all printers */
for (i = 0; i < num_printers; i++) {