summaryrefslogtreecommitdiff
path: root/source3/utils
diff options
context:
space:
mode:
authorDerrell Lipman <derrell@samba.org>2005-03-30 04:40:24 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 10:56:24 -0500
commit934d41d23956c663406ff9d68e5a8ba9d81b5096 (patch)
tree5680eab3013a7e2f364d8ca8782bfb32d285ab99 /source3/utils
parent7387dab585dadf710dbb72ddd211db1a1ba725c7 (diff)
downloadsamba-934d41d23956c663406ff9d68e5a8ba9d81b5096.tar.gz
samba-934d41d23956c663406ff9d68e5a8ba9d81b5096.tar.bz2
samba-934d41d23956c663406ff9d68e5a8ba9d81b5096.zip
r6127: Eliminated all compiler warnings pertaining to mismatched "qualifiers". The
whole of samba comiles warning-free with the default compiler flags. Temporarily defined -Wall to locate other potential problems. Found an unused static function (#ifdefed out rather than deleted, in case it's needed for something in progress). There are also a number of uses of undeclared functions, mostly krb5_*. Files with these problems need to have appropriate header files included, but they are not fixed in this update. oplock_linux.c.c has undefined functions capget() and capset(), which need to have "#undef _POSIX_SOURCE" specified before including <sys/capability.h>, but that could potentially have other side effects, so that remains uncorrected as well. The flag -Wall should be added permanently to CFLAGS, and all warnings then generated should be eliminated. (This used to be commit 5b19ede88ed80318e392f8017f4573fbb2ecbe0f)
Diffstat (limited to 'source3/utils')
-rw-r--r--source3/utils/net_ads.c2
-rw-r--r--source3/utils/net_lookup.c2
-rw-r--r--source3/utils/smbcontrol.c2
3 files changed, 3 insertions, 3 deletions
diff --git a/source3/utils/net_ads.c b/source3/utils/net_ads.c
index 9c00f05bfb..83fdb08a9a 100644
--- a/source3/utils/net_ads.c
+++ b/source3/utils/net_ads.c
@@ -81,7 +81,7 @@ static int net_ads_lookup(int argc, const char **argv)
d_printf("Didn't find the cldap server!\n");
return -1;
} if (!ads->config.realm) {
- ads->config.realm = opt_target_workgroup;
+ ads->config.realm = (char *) opt_target_workgroup;
ads->ldap_port = 389;
}
diff --git a/source3/utils/net_lookup.c b/source3/utils/net_lookup.c
index 7e5f12da45..7f7a88c66d 100644
--- a/source3/utils/net_lookup.c
+++ b/source3/utils/net_lookup.c
@@ -209,7 +209,7 @@ static int net_lookup_kdc(int argc, const char **argv)
realm.length = strlen(realm.data);
}
- rc = krb5_locate_kdc(ctx, &realm, &addrs, &num_kdcs, 0);
+ rc = krb5_locate_kdc(ctx, &realm, (struct sockaddr **) &addrs, &num_kdcs, 0);
if (rc) {
DEBUG(1, ("krb5_locate_kdc failed (%s)\n", error_message(rc)));
return -1;
diff --git a/source3/utils/smbcontrol.c b/source3/utils/smbcontrol.c
index 2eb661c8b6..154bc5b1ae 100644
--- a/source3/utils/smbcontrol.c
+++ b/source3/utils/smbcontrol.c
@@ -428,7 +428,7 @@ static BOOL do_printnotify(const pid_t pid, const int argc, const char **argv)
return False;
}
- notify_printer_byname(argv[2], attribute, argv[4]);
+ notify_printer_byname(argv[2], attribute, (char *) argv[4]);
goto send;
}