Replace sid_string_static with sid_to_string

This adds 28 fstrings on the stack, but I think an fstring on the stack is
still far better than a static one.
(This used to be commit c7c885078be8fd3024c186044ac28275d7609679)

1 files changed, 4 insertions, 2 deletions

diff --git a/source3/winbindd/winbindd_group.c b/source3/winbindd/winbindd_group.c
index dc8cebf92f..49562a112c 100644
--- a/source3/winbindd/winbindd_group.c
+++ b/source3/winbindd/winbindd_group.c
@@ -1648,7 +1648,8 @@ static void getusersids_recv(void *private_data, bool success, DOM_SID *sids,
 
 	/* work out the response size */
 	for (i = 0; i < num_sids; i++) {
-		const char *s = sid_string_static(&sids[i]);
+		fstring s;
+		sid_to_string(s, &sids[i]);
 		ret_size += strlen(s) + 1;
 	}
 
@@ -1661,7 +1662,8 @@ static void getusersids_recv(void *private_data, bool success, DOM_SID *sids,
 	}
 	ofs = 0;
 	for (i = 0; i < num_sids; i++) {
-		const char *s = sid_string_static(&sids[i]);
+		fstring s;
+		sid_to_string(s, &sids[i]);
 		safe_strcpy(ret + ofs, s, ret_size - ofs - 1);
 		ofs += strlen(ret+ofs) + 1;
 	}