summaryrefslogtreecommitdiff
path: root/source3/winbindd
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2010-04-29 12:11:04 +0200
committerVolker Lendecke <vl@samba.org>2010-04-29 14:33:08 +0200
commitfcdba1b36ffc3cfdeac71863f26a1605d3b24fa5 (patch)
treedf9f35637d40e9444994a02f286df5c6129315ea /source3/winbindd
parent81e75bacd346384a3e0ac3b2d73cb1981fe278d1 (diff)
downloadsamba-fcdba1b36ffc3cfdeac71863f26a1605d3b24fa5.tar.gz
samba-fcdba1b36ffc3cfdeac71863f26a1605d3b24fa5.tar.bz2
samba-fcdba1b36ffc3cfdeac71863f26a1605d3b24fa5.zip
s3: Fix an uninitialized variable in idmap_tdb2_sid_to_id()
When we find an invalid record in the database, there's no point in checking the non-existing value against the range limits.
Diffstat (limited to 'source3/winbindd')
-rw-r--r--source3/winbindd/idmap_tdb2.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/source3/winbindd/idmap_tdb2.c b/source3/winbindd/idmap_tdb2.c
index ec83cae8a3..3e2021457a 100644
--- a/source3/winbindd/idmap_tdb2.c
+++ b/source3/winbindd/idmap_tdb2.c
@@ -750,6 +750,7 @@ static NTSTATUS idmap_tdb2_sid_to_id(struct idmap_tdb2_context *ctx, struct id_m
} else { /* Unknown record type ! */
DEBUG(2, ("Found INVALID record %s -> %s\n", keystr, (const char *)data.dptr));
ret = NT_STATUS_INTERNAL_DB_ERROR;
+ goto done;
}
/* apply filters before returning result */