diff options
| author | Volker Lendecke <vlendec@samba.org> | 2005-05-13 09:18:50 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 10:56:54 -0500 |
| commit | 0e5aa494dd57a598ce1ac6e7141273fbe7bcf113 (patch) | |
| tree | edceac3eeb72333fc3a121ed3581fbd061b10ee0 /source3 | |
| parent | 8bb2b294f384753a1ac78ed722a38336e4ad191f (diff) | |
| download | samba-0e5aa494dd57a598ce1ac6e7141273fbe7bcf113.tar.gz samba-0e5aa494dd57a598ce1ac6e7141273fbe7bcf113.tar.bz2 samba-0e5aa494dd57a598ce1ac6e7141273fbe7bcf113.zip | |
r6772: Fix a valgrind error for samr_open_alias uncovered by one of John's test.
Jerry, in query_aliasmem, set_aliasinfo and set_groupinfo (and possibly
others) need become_root()/unbecome_root() around the pdb calls. I'm not sure
I would do the access checks correctly, I would much rather leave that to
you.
Volker
(This used to be commit 88a67e96d1c54fddadbb6a33e4bc5fba884e58e6)
Diffstat (limited to 'source3')
| -rw-r--r-- | source3/rpc_server/srv_samr_nt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/rpc_server/srv_samr_nt.c b/source3/rpc_server/srv_samr_nt.c index 69298bcd5d..e4588b2e61 100644 --- a/source3/rpc_server/srv_samr_nt.c +++ b/source3/rpc_server/srv_samr_nt.c @@ -2389,7 +2389,7 @@ NTSTATUS _samr_open_alias(pipes_struct *p, SAMR_Q_OPEN_ALIAS *q_u, SAMR_R_OPEN_A make_samr_object_sd(p->mem_ctx, &psd, &sd_size, &ali_generic_mapping, NULL, 0); se_map_generic(&des_access,&ali_generic_mapping); - se_priv_add( &se_rights, &se_add_users ); + se_priv_copy( &se_rights, &se_add_users ); status = access_check_samr_object(psd, p->pipe_user.nt_user_token, |