summaryrefslogtreecommitdiff
path: root/source3
diff options
context:
space:
mode:
authorMichael Adam <obnox@samba.org>2012-12-04 02:02:07 +0100
committerStefan Metzmacher <metze@samba.org>2012-12-04 09:03:25 +0100
commit4a8028a96e20f140c2d423efd4c010a7d300ca72 (patch)
treecf2d34a28de3dcd1a85679e293561edecc36cfd9 /source3
parent61e8b80c85bf114da7f1d3dadfc2207564f5fbaa (diff)
downloadsamba-4a8028a96e20f140c2d423efd4c010a7d300ca72.tar.gz
samba-4a8028a96e20f140c2d423efd4c010a7d300ca72.tar.bz2
samba-4a8028a96e20f140c2d423efd4c010a7d300ca72.zip
s3:smbd:vfs_acl: fix a PANIC when setting an ACL fails with ACCESS_DENIED
Omission to free the talloc frame causes a panic (at least in developer mode) in the next main event loop due to "Frame not freed in order." (Freed frame ../source3/smbd/process.c:3617, expected ../source3/modules/vfs_acl_common.c:534.) Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Dec 4 09:03:25 CET 2012 on sn-devel-104
Diffstat (limited to 'source3')
-rw-r--r--source3/modules/vfs_acl_common.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/source3/modules/vfs_acl_common.c b/source3/modules/vfs_acl_common.c
index 59ced2922f..4e3aa72d37 100644
--- a/source3/modules/vfs_acl_common.c
+++ b/source3/modules/vfs_acl_common.c
@@ -590,6 +590,7 @@ static NTSTATUS fset_nt_acl_common(vfs_handle_struct *handle, files_struct *fsp,
if (get_current_uid(handle->conn) == 0 ||
chown_needed == false ||
!(fsp->access_mask & SEC_STD_WRITE_OWNER)) {
+ TALLOC_FREE(frame);
return NT_STATUS_ACCESS_DENIED;
}