summaryrefslogtreecommitdiff
path: root/source3
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2008-08-31 11:34:01 +0200
committerVolker Lendecke <vl@samba.org>2008-08-31 11:36:27 +0200
commitec4015d34fed1f0a53ae495d9d9b2744f0c29df0 (patch)
tree8987f8b80793e9ef0275a2a932a09bc8ae347e26 /source3
parent8f525afbd2f2a849086c60ee890218a070cecd34 (diff)
downloadsamba-ec4015d34fed1f0a53ae495d9d9b2744f0c29df0.tar.gz
samba-ec4015d34fed1f0a53ae495d9d9b2744f0c29df0.tar.bz2
samba-ec4015d34fed1f0a53ae495d9d9b2744f0c29df0.zip
Fix Coverity ID 592
The scanner did not figure out that we always have a primary domain, so it complained about us potentially passing a NULL pointer down to set_domain_online_request() where it is dereferenced. Make the code a bit clearer. (This used to be commit e6e8d108f95ed974f98f3f57adcfbbde4e00fad9)
Diffstat (limited to 'source3')
-rw-r--r--source3/winbindd/winbindd_dual.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/source3/winbindd/winbindd_dual.c b/source3/winbindd/winbindd_dual.c
index 916e8c07c7..63ce0e8d7f 100644
--- a/source3/winbindd/winbindd_dual.c
+++ b/source3/winbindd/winbindd_dual.c
@@ -1212,6 +1212,10 @@ static bool fork_domain_child(struct winbindd_child *child)
}
}
+ if (primary_domain == NULL) {
+ smb_panic("no primary domain found");
+ }
+
/* Ensure we're not handling an event inherited from
our parent. */