diff options
| author | Richard Sharpe <realrichardsharpe@gmail.com> | 2013-07-22 16:04:43 -0700 |
|---|---|---|
| committer | Richard Sharpe <sharpe@samba.org> | 2013-08-03 17:41:22 +0200 |
| commit | 852c9ac34dbef66d0b2619554c611157c2fab771 (patch) | |
| tree | ff01a4912364f69e2933ff4446cc57a7dfa9c0a4 /source3 | |
| parent | 859182da6d06be0e9d37d7ed3448efc3dc78bdb2 (diff) | |
| download | samba-852c9ac34dbef66d0b2619554c611157c2fab771.tar.gz samba-852c9ac34dbef66d0b2619554c611157c2fab771.tar.bz2 samba-852c9ac34dbef66d0b2619554c611157c2fab771.zip | |
There are tests all over the SMB1 code to check that srv_send_smb fails, but it never returns false.
Even if the write to the socket/fd fails, we never return false and
will keep reading stuff off of the input buffer until it is exhausted
and then we will exit.
Signed-off-by: Richard Sharpe <rsharpe@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Richard Sharpe <sharpe@samba.org>
Autobuild-Date(master): Sat Aug 3 17:41:22 CEST 2013 on sn-devel-104
Diffstat (limited to 'source3')
| -rw-r--r-- | source3/smbd/process.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/smbd/process.c b/source3/smbd/process.c index 5ef0fd335e..3fbfc37578 100644 --- a/source3/smbd/process.c +++ b/source3/smbd/process.c @@ -194,7 +194,7 @@ out: SMB_PERFCOUNT_END(pcd); smbd_unlock_socket(sconn); - return true; + return (ret > 0); } /******************************************************************* |