diff options
author | Jeremy Allison <jra@samba.org> | 2011-03-30 09:58:22 -0700 |
---|---|---|
committer | Jeremy Allison <jra@samba.org> | 2011-03-30 09:58:22 -0700 |
commit | c964744001cd231e585c5c5c9016becda145340b (patch) | |
tree | aefc0ccdd0cc62f3f238c185b37313b13f3830b9 /source3 | |
parent | 8f4e39f6f7636ad36d686a52aaefc18a411a7f02 (diff) | |
download | samba-c964744001cd231e585c5c5c9016becda145340b.tar.gz samba-c964744001cd231e585c5c5c9016becda145340b.tar.bz2 samba-c964744001cd231e585c5c5c9016becda145340b.zip |
This doesn't look like it has anything to do with character set conversion, but it does :-).
Turns out one of the *really* significant differences between
convert_string() in source4 and source3, is that the one in
source3 will return 0 for byte length converted when called
with dest_len = 0 whereas the one in source4 returns (size_t)-1
and sets errno to E2BIG.
Allow the ndr_string code to cope with the (arguably correct)
way that the source4 implementation works. This code only gets
excercised in the print spooler tests, which aren't run in source4,
which is why this bug has lasted for so long.
You don't want to know how long it took me to find this :-).
Jeremy.
Diffstat (limited to 'source3')
0 files changed, 0 insertions, 0 deletions