summaryrefslogtreecommitdiff
path: root/source3
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2008-06-27 11:13:07 +0200
committerVolker Lendecke <vl@samba.org>2008-06-27 11:23:20 +0200
commitf287cdb1f046ccd5868c0553b6a79643f9782b01 (patch)
tree6114384fef917bf2068761a5e9ab50e01f0fdea4 /source3
parent799252f635a4cf1790a24f9ba8765dba9fb7df86 (diff)
downloadsamba-f287cdb1f046ccd5868c0553b6a79643f9782b01.tar.gz
samba-f287cdb1f046ccd5868c0553b6a79643f9782b01.tar.bz2
samba-f287cdb1f046ccd5868c0553b6a79643f9782b01.zip
Remove a strlen check that will never kick in
strlen(str)<2 will be caught by the explicit tests for str[0] and str[1] in the lines above this. Jerry, please check! Volker (This used to be commit 44a9e5b713c25ff2cc7215635a516f25359b045b)
Diffstat (limited to 'source3')
-rw-r--r--source3/nsswitch/libwbclient/wbc_sid.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/source3/nsswitch/libwbclient/wbc_sid.c b/source3/nsswitch/libwbclient/wbc_sid.c
index b0909263fc..eb115e1297 100644
--- a/source3/nsswitch/libwbclient/wbc_sid.c
+++ b/source3/nsswitch/libwbclient/wbc_sid.c
@@ -102,8 +102,7 @@ wbcErr wbcStringToSid(const char *str,
if (!str
|| (str[0]!='S' && str[0]!='s')
- || (str[1]!='-')
- || (strlen(str)<2))
+ || (str[1]!='-'))
{
wbc_status = WBC_ERR_INVALID_PARAM;
BAIL_ON_WBC_ERROR(wbc_status);