summaryrefslogtreecommitdiff
path: root/source3
diff options
context:
space:
mode:
authorAndrew Bartlett <abartlet@samba.org>2009-04-16 14:08:00 +1000
committerAndrew Bartlett <abartlet@samba.org>2009-04-16 14:08:00 +1000
commit34193cffc0900d8563822a9524f87b76d93ee80e (patch)
tree060861c162d76d27603efde0647adb1cdd631dea /source3
parentb57c8ff4400e5f2bd0776247496b34dab68bde97 (diff)
downloadsamba-34193cffc0900d8563822a9524f87b76d93ee80e.tar.gz
samba-34193cffc0900d8563822a9524f87b76d93ee80e.tar.bz2
samba-34193cffc0900d8563822a9524f87b76d93ee80e.zip
Fix crash bug in NTLMSSP caused by msrpc_parse() moving to talloc
Diffstat (limited to 'source3')
-rw-r--r--source3/libsmb/ntlmssp.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/source3/libsmb/ntlmssp.c b/source3/libsmb/ntlmssp.c
index 80c003283e..a1672af068 100644
--- a/source3/libsmb/ntlmssp.c
+++ b/source3/libsmb/ntlmssp.c
@@ -1046,7 +1046,7 @@ static NTSTATUS ntlmssp_client_challenge(struct ntlmssp_state *ntlmssp_state,
DEBUG(3, ("NTLMSSP: Set final flags:\n"));
debug_ntlmssp_flags(ntlmssp_state->neg_flags);
- if (!msrpc_parse(NULL, &reply, chal_parse_string,
+ if (!msrpc_parse(ntlmssp_state, &reply, chal_parse_string,
"NTLMSSP",
&ntlmssp_command,
&server_domain,
@@ -1059,10 +1059,8 @@ static NTSTATUS ntlmssp_client_challenge(struct ntlmssp_state *ntlmssp_state,
return NT_STATUS_INVALID_PARAMETER;
}
- ntlmssp_state->server_domain = talloc_strdup(ntlmssp_state,
- server_domain);
+ ntlmssp_state->server_domain = server_domain;
- SAFE_FREE(server_domain);
if (challenge_blob.length != 8) {
data_blob_free(&struct_blob);
return NT_STATUS_INVALID_PARAMETER;