summaryrefslogtreecommitdiff
path: root/source3
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2011-03-16 21:47:10 +0100
committerVolker Lendecke <vl@samba.org>2011-03-16 22:07:24 +0100
commitdacb392db6b7585bffe00fae11aab4cc6225c072 (patch)
tree5fda0cf0076a7a54faccf726256969aa2ddce837 /source3
parentfb47b7fd67567fd84865e82bca91c1c32f36771f (diff)
downloadsamba-dacb392db6b7585bffe00fae11aab4cc6225c072.tar.gz
samba-dacb392db6b7585bffe00fae11aab4cc6225c072.tar.bz2
samba-dacb392db6b7585bffe00fae11aab4cc6225c072.zip
s3: Fix Coverity ID 2234: REVERSE_INULL
We have dereferenced "b" already in dcerpc_samr_Connect2 in line 521
Diffstat (limited to 'source3')
-rw-r--r--source3/rpc_server/netlogon/srv_netlog_nt.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/source3/rpc_server/netlogon/srv_netlog_nt.c b/source3/rpc_server/netlogon/srv_netlog_nt.c
index 8e766328f5..bfa3bb25e8 100644
--- a/source3/rpc_server/netlogon/srv_netlog_nt.c
+++ b/source3/rpc_server/netlogon/srv_netlog_nt.c
@@ -617,10 +617,10 @@ static NTSTATUS samr_find_machine_account(TALLOC_CTX *mem_ctx,
}
out:
- if (b && is_valid_policy_hnd(&domain_handle)) {
+ if (is_valid_policy_hnd(&domain_handle)) {
dcerpc_samr_Close(b, mem_ctx, &domain_handle, &result);
}
- if (b && is_valid_policy_hnd(&connect_handle)) {
+ if (is_valid_policy_hnd(&connect_handle)) {
dcerpc_samr_Close(b, mem_ctx, &connect_handle, &result);
}