* the RPC-ECHO pipe now works in smbd, as long as the data sizes

   don't cause fragmented pdus (I'll add fragments shortly)

 * change data_blob_talloc() to not zero memory when the 2nd argument
   is NULL. The zeroing just masks bugs, and can't even allow a DOS
   attack

 * modified pidl to ensure that [ref] arguments to the out side of
   functions are allocated when parsing the in side. This allows rpc
   backends to assume that [ref] variables are all setup. Doesn't work
   correctly for [ref] arrays yet

 * changed DLIST_ADD_END() to take the type instead of a tmp
   variable. This means you don't need to declare a silly tmp variable in
   the caller
(This used to be commit 46e0a358198eeb9af1907ee2a29025d3ab23b6d1)

2 files changed, 2 insertions, 4 deletions

diff --git a/source4/auth/auth.c b/source4/auth/auth.c
index 514a6bde6a..2dc14248f9 100644
--- a/source4/auth/auth.c
+++ b/source4/auth/auth.c
@@ -324,7 +324,6 @@ static NTSTATUS make_auth_context_text_list(struct auth_context **auth_context,
 {
 	auth_methods *list = NULL;
 	auth_methods *t = NULL;
-	auth_methods *tmp;
 	int i;
 	NTSTATUS nt_status;
 
@@ -358,7 +357,7 @@ static NTSTATUS make_auth_context_text_list(struct auth_context **auth_context,
 				if (NT_STATUS_IS_OK(builtin_auth_init_functions[i].init(*auth_context, module_params, &t))) {
 					DEBUG(5,("make_auth_context_text_list: auth method %s has a valid init\n",
 								*text_list));
-					DLIST_ADD_END(list, t, tmp);
+					DLIST_ADD_END(list, t, auth_methods *);
 				} else {
 					DEBUG(0,("make_auth_context_text_list: auth method %s did not correctly init\n",
 								*text_list));
diff --git a/source4/auth/pampass.c b/source4/auth/pampass.c
index 045ceb7c72..a5c9a5de16 100644
--- a/source4/auth/pampass.c
+++ b/source4/auth/pampass.c
@@ -208,7 +208,6 @@ static struct chat_struct *make_pw_chat(char *p)
 	fstring reply;
 	struct chat_struct *list = NULL;
 	struct chat_struct *t;
-	struct chat_struct *tmp;
 
 	while (1) {
 		t = (struct chat_struct *)malloc(sizeof(*t));
@@ -219,7 +218,7 @@ static struct chat_struct *make_pw_chat(char *p)
 
 		ZERO_STRUCTP(t);
 
-		DLIST_ADD_END(list, t, tmp);
+		DLIST_ADD_END(list, t, struct chat_struct *);
 
 		if (!next_token(&p, prompt, NULL, sizeof(fstring)))
 			break;