r24698: Patch from Andrew Kroeger <andrew@sprocks.gotdns.com> to fix Bug

#4521: smbclient crashes during tab completion when tab hit twice.

The readline magic is beyond me, but this seems to do the trick.

Andrew Bartlett
(This used to be commit e05f3450ecc3f99509fbc069b09d402e3b6d7564)

1 files changed, 4 insertions, 3 deletions

diff --git a/source4/client/client.c b/source4/client/client.c
index a10d4254a3..1fdbec4bfd 100644
--- a/source4/client/client.c
+++ b/source4/client/client.c
@@ -2922,9 +2922,10 @@ static char **completion_fn(const char *text, int start, int end)
 		return matches;
 
 cleanup:
-		while (i >= 0) {
-			free(matches[i]);
-			i--;
+		count--;
+		while (count >= 0) {
+			free(matches[count]);
+			count--;
 		}
 		free(matches);
 		return NULL;