diff options
| author | Andrew Tridgell <tridge@samba.org> | 2009-12-16 20:45:02 +1100 |
|---|---|---|
| committer | Andrew Tridgell <tridge@samba.org> | 2009-12-16 20:56:24 +1100 |
| commit | 558a38671af5ea05d9ee1d815f0c1c2dab41a80c (patch) | |
| tree | 19752f35e1b1868425157accb0a96456ad6bcbb3 /source4/dsdb/samdb/ldb_modules/lazy_commit.c | |
| parent | 41e403adb0fa76c8d15d5d1ef38b195a6da2265c (diff) | |
| download | samba-558a38671af5ea05d9ee1d815f0c1c2dab41a80c.tar.gz samba-558a38671af5ea05d9ee1d815f0c1c2dab41a80c.tar.bz2 samba-558a38671af5ea05d9ee1d815f0c1c2dab41a80c.zip | |
s4-dsdb: it is a better pattern to mark a control as done than remove it
removing a control means it can't be seen by any other modules, which
is usually not what is wanted. Better to just mark it non-critical,
which means anyone else who wants to look at it can, but if nobody
does its not an error.
Diffstat (limited to 'source4/dsdb/samdb/ldb_modules/lazy_commit.c')
| -rw-r--r-- | source4/dsdb/samdb/ldb_modules/lazy_commit.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/source4/dsdb/samdb/ldb_modules/lazy_commit.c b/source4/dsdb/samdb/ldb_modules/lazy_commit.c index 69ac99e246..0502b2efa1 100644 --- a/source4/dsdb/samdb/ldb_modules/lazy_commit.c +++ b/source4/dsdb/samdb/ldb_modules/lazy_commit.c @@ -33,7 +33,6 @@ static int unlazy_op(struct ldb_module *module, struct ldb_request *req) { int ret; struct ldb_request *new_req; - struct ldb_control **saved_controls; struct ldb_control *control = ldb_request_get_control(req, LDB_CONTROL_SERVER_LAZY_COMMIT); if (!control) { return ldb_next_request(module, req); @@ -99,7 +98,7 @@ static int unlazy_op(struct ldb_module *module, struct ldb_request *req) return ret; } - save_controls(control, req, &saved_controls); + control->critical = 0; return ldb_next_request(module, new_req); } |