diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2010-11-26 10:11:30 +1100 |
|---|---|---|
| committer | Matthias Dieter Wallnöfer <mdw@samba.org> | 2010-11-26 13:10:00 +0100 |
| commit | 7048ad11f518b88897a73fb5e0a46520b703a7d6 (patch) | |
| tree | 730271cc221f395edc75b90487801c295824c2ee /source4/dsdb/samdb/ldb_modules/update_keytab.c | |
| parent | 439a2d69831aea4a737e5e0e35226a551b11ad29 (diff) | |
| download | samba-7048ad11f518b88897a73fb5e0a46520b703a7d6.tar.gz samba-7048ad11f518b88897a73fb5e0a46520b703a7d6.tar.bz2 samba-7048ad11f518b88897a73fb5e0a46520b703a7d6.zip | |
s4-dsdb Reorganise and clarify the LSA objectClass check (forbidden on LDAP)
This arranged the check to avoid talloc_strdup() (the schema pointers
are constant, and can be relied upon), and checks the untrusted bit
first (it is faster), before the ldb_attr_cmp().
The strcmp() here was valid, if unusual, because the ldapDisplayName
values are already in the correct case, but strcasecmp() is more
correct, as for the small extra cost, we avoid a difficult to diagnose
bug later.
Andrew Bartlett
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Diffstat (limited to 'source4/dsdb/samdb/ldb_modules/update_keytab.c')
0 files changed, 0 insertions, 0 deletions