summaryrefslogtreecommitdiff
path: root/source4/dsdb/samdb
diff options
context:
space:
mode:
authorMatthieu Patou <mat@matws.net>2012-04-15 21:58:49 -0700
committerMatthieu Patou <mat@matws.net>2012-05-05 17:26:11 -0700
commit191dd54cbc42fc4816f249742d3488d091d96a26 (patch)
tree135efff88c9d3e3d2ba931889fddd508d1e9fcb7 /source4/dsdb/samdb
parentaae8085c618e3b4a994a5316596f031701b0529f (diff)
downloadsamba-191dd54cbc42fc4816f249742d3488d091d96a26.tar.gz
samba-191dd54cbc42fc4816f249742d3488d091d96a26.tar.bz2
samba-191dd54cbc42fc4816f249742d3488d091d96a26.zip
s4: use intermediate var, increase lisibility
Diffstat (limited to 'source4/dsdb/samdb')
-rw-r--r--source4/dsdb/samdb/ldb_modules/objectclass_attrs.c11
1 files changed, 5 insertions, 6 deletions
diff --git a/source4/dsdb/samdb/ldb_modules/objectclass_attrs.c b/source4/dsdb/samdb/ldb_modules/objectclass_attrs.c
index 1fd850ab90..1fc2752016 100644
--- a/source4/dsdb/samdb/ldb_modules/objectclass_attrs.c
+++ b/source4/dsdb/samdb/ldb_modules/objectclass_attrs.c
@@ -329,12 +329,11 @@ static int attr_handler2(struct oc_context *ac)
* 3.1.1.5. Unlike other objects in the DS, TDOs may not be created or
* manipulated by client machines over the LDAPv3 transport."
*/
- if (ldb_req_is_untrusted(ac->req)) {
- for (i = 0; i < oc_element->num_values; i++) {
- if ((strcmp((char *)oc_element->values[i].data,
- "secret") == 0) ||
- (strcmp((char *)oc_element->values[i].data,
- "trustedDomain") == 0)) {
+ for (i = 0; i < oc_element->num_values; i++) {
+ char * attname = (char *)oc_element->values[i].data;
+ if (ldb_req_is_untrusted(ac->req)) {
+ if (strcmp(attname, "secret") == 0 ||
+ strcmp(attname, "trustedDomain") == 0) {
ldb_asprintf_errstring(ldb, "objectclass_attrs: LSA objectclasses (entry '%s') cannot be created or changed over LDAP!",
ldb_dn_get_linearized(ac->search_res->message->dn));
return LDB_ERR_UNWILLING_TO_PERFORM;