diff options
author | Kamen Mazdrashki <kamenim@samba.org> | 2010-04-08 05:30:16 +0300 |
---|---|---|
committer | Kamen Mazdrashki <kamenim@samba.org> | 2010-04-09 12:21:31 +0300 |
commit | c3d77989913a1ec270a50847922f6c1ffd7cbad0 (patch) | |
tree | c232e221253eaf614862db166e7e4218810a4291 /source4/dsdb/schema/schema_init.c | |
parent | e5ef11f4e29af77147dc21e6e8986ed091818566 (diff) | |
download | samba-c3d77989913a1ec270a50847922f6c1ffd7cbad0.tar.gz samba-c3d77989913a1ec270a50847922f6c1ffd7cbad0.tar.bz2 samba-c3d77989913a1ec270a50847922f6c1ffd7cbad0.zip |
s4/dsdb: Use dsdb_schema_info object to verify schema_info blobs
Diffstat (limited to 'source4/dsdb/schema/schema_init.c')
-rw-r--r-- | source4/dsdb/schema/schema_init.c | 26 |
1 files changed, 12 insertions, 14 deletions
diff --git a/source4/dsdb/schema/schema_init.c b/source4/dsdb/schema/schema_init.c index c7fcdaecdc..2f9abea303 100644 --- a/source4/dsdb/schema/schema_init.c +++ b/source4/dsdb/schema/schema_init.c @@ -104,27 +104,24 @@ WERROR dsdb_load_oid_mappings_ldb(struct dsdb_schema *schema, const struct ldb_val *prefixMap, const struct ldb_val *schemaInfo) { - WERROR status; + WERROR werr; const char *schema_info; struct dsdb_schema_prefixmap *pfm; + struct dsdb_schema_info *schi; TALLOC_CTX *mem_ctx; - /* verify input params */ - if (schemaInfo->length != 21) { - return WERR_INVALID_PARAMETER; - } - if (schemaInfo->data[0] != 0xFF) { - return WERR_INVALID_PARAMETER; - } - mem_ctx = talloc_new(schema); W_ERROR_HAVE_NO_MEMORY(mem_ctx); + /* parse schemaInfo blob to verify it is valid */ + werr = dsdb_schema_info_from_blob(schemaInfo, mem_ctx, &schi); + W_ERROR_NOT_OK_GOTO(werr, DONE); + /* fetch prefixMap */ - status = _dsdb_prefixmap_from_ldb_val(prefixMap, - schema->iconv_convenience, - mem_ctx, &pfm); - W_ERROR_NOT_OK_RETURN(status); + werr = _dsdb_prefixmap_from_ldb_val(prefixMap, + schema->iconv_convenience, + mem_ctx, &pfm); + W_ERROR_NOT_OK_GOTO(werr, DONE); /* decode schema_info */ schema_info = hex_encode_talloc(mem_ctx, @@ -142,10 +139,11 @@ WERROR dsdb_load_oid_mappings_ldb(struct dsdb_schema *schema, talloc_free(discard_const(schema->schema_info)); schema->schema_info = talloc_steal(schema, schema_info); +DONE: /* clean up locally allocated mem */ talloc_free(mem_ctx); - return WERR_OK; + return werr; } WERROR dsdb_get_oid_mappings_drsuapi(const struct dsdb_schema *schema, |