diff options
| author | Matthias Dieter Wallnöfer <mdw@samba.org> | 2013-05-29 22:17:35 +0200 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2013-06-05 03:26:25 +0200 |
| commit | 1a6eac2c37f4d80033e450731bd36a9af4b2bd1d (patch) | |
| tree | 509f547fe991b5f8ec2779315bfe170c9b12bb08 /source4/dsdb | |
| parent | 62ee2a5caf8b8e7750a650c7ebc9729beda48a89 (diff) | |
| download | samba-1a6eac2c37f4d80033e450731bd36a9af4b2bd1d.tar.gz samba-1a6eac2c37f4d80033e450731bd36a9af4b2bd1d.tar.bz2 samba-1a6eac2c37f4d80033e450731bd36a9af4b2bd1d.zip | |
s4:samldb LDB module - permit "userAccountControl" modifications without acct. type
Obviously this defaults to UF_NORMAL_ACCOUNT. Some background can be found in
MS-SAMR section 3.1.1.8.10.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jun 5 03:26:25 CEST 2013 on sn-devel-104
Diffstat (limited to 'source4/dsdb')
| -rw-r--r-- | source4/dsdb/samdb/ldb_modules/samldb.c | 28 | ||||
| -rwxr-xr-x | source4/dsdb/tests/python/sam.py | 32 |
2 files changed, 58 insertions, 2 deletions
diff --git a/source4/dsdb/samdb/ldb_modules/samldb.c b/source4/dsdb/samdb/ldb_modules/samldb.c index cd13900bf5..5bb0b61d61 100644 --- a/source4/dsdb/samdb/ldb_modules/samldb.c +++ b/source4/dsdb/samdb/ldb_modules/samldb.c @@ -1517,8 +1517,32 @@ static int samldb_user_account_control_change(struct samldb_ctx *ac) account_type = ds_uf2atype(user_account_control); if (account_type == 0) { - ldb_set_errstring(ldb, "samldb: Unrecognized account type!"); - return LDB_ERR_UNWILLING_TO_PERFORM; + char *tempstr; + + /* + * When there is no account type embedded in "userAccountControl" + * fall back to default "UF_NORMAL_ACCOUNT". + */ + if (user_account_control == 0) { + ldb_set_errstring(ldb, + "samldb: Invalid user account control value!"); + return LDB_ERR_UNWILLING_TO_PERFORM; + } + + user_account_control |= UF_NORMAL_ACCOUNT; + + tempstr = talloc_asprintf(ac->msg, "%d", user_account_control); + if (tempstr == NULL) { + return ldb_module_oom(ac->module); + } + + /* Overwrite "userAccountControl" with "UF_NORMAL_ACCOUNT" added */ + el = dsdb_get_single_valued_attr(ac->msg, "userAccountControl", + ac->req->operation); + el->values[0].data = (uint8_t *) tempstr; + el->values[0].length = strlen(tempstr); + + account_type = ATYPE_NORMAL_ACCOUNT; } ret = samdb_msg_add_uint(ldb, ac->msg, ac->msg, "sAMAccountType", account_type); diff --git a/source4/dsdb/tests/python/sam.py b/source4/dsdb/tests/python/sam.py index df1915a899..361a10898d 100755 --- a/source4/dsdb/tests/python/sam.py +++ b/source4/dsdb/tests/python/sam.py @@ -1571,6 +1571,22 @@ class SamTests(samba.tests.TestCase): ATYPE_NORMAL_ACCOUNT) self.assertTrue(int(res1[0]["userAccountControl"][0]) & UF_ACCOUNTDISABLE == 0) + m = Message() + m.dn = Dn(ldb, "cn=ldaptestuser,cn=users," + self.base_dn) + m["userAccountControl"] = MessageElement( + str(UF_ACCOUNTDISABLE), + FLAG_MOD_REPLACE, "userAccountControl") + ldb.modify(m) + + res1 = ldb.search("cn=ldaptestuser,cn=users," + self.base_dn, + scope=SCOPE_BASE, + attrs=["sAMAccountType", "userAccountControl"]) + self.assertTrue(len(res1) == 1) + self.assertEquals(int(res1[0]["sAMAccountType"][0]), + ATYPE_NORMAL_ACCOUNT) + self.assertTrue(int(res1[0]["userAccountControl"][0]) & UF_NORMAL_ACCOUNT != 0) + self.assertTrue(int(res1[0]["userAccountControl"][0]) & UF_ACCOUNTDISABLE != 0) + try: m = Message() m.dn = Dn(ldb, "cn=ldaptestuser,cn=users," + self.base_dn) @@ -1791,6 +1807,22 @@ class SamTests(samba.tests.TestCase): ATYPE_NORMAL_ACCOUNT) self.assertTrue(int(res1[0]["userAccountControl"][0]) & UF_ACCOUNTDISABLE == 0) + m = Message() + m.dn = Dn(ldb, "cn=ldaptestcomputer,cn=computers," + self.base_dn) + m["userAccountControl"] = MessageElement( + str(UF_ACCOUNTDISABLE), + FLAG_MOD_REPLACE, "userAccountControl") + ldb.modify(m) + + res1 = ldb.search("cn=ldaptestcomputer,cn=computers," + self.base_dn, + scope=SCOPE_BASE, + attrs=["sAMAccountType", "userAccountControl"]) + self.assertTrue(len(res1) == 1) + self.assertEquals(int(res1[0]["sAMAccountType"][0]), + ATYPE_NORMAL_ACCOUNT) + self.assertTrue(int(res1[0]["userAccountControl"][0]) & UF_NORMAL_ACCOUNT != 0) + self.assertTrue(int(res1[0]["userAccountControl"][0]) & UF_ACCOUNTDISABLE != 0) + try: m = Message() m.dn = Dn(ldb, "cn=ldaptestcomputer,cn=computers," + self.base_dn) |