r2674: I have realised that talloc() should have its context marked const, as

a const pointer really means that "the data pointed to by this pointer
won't change", and that is certainly true of talloc(). The fact that
some behind-the-scenes meta-data can change doesn't matter from the
point of view of const.

this fixes a number of const warnings caused by const data structures
being passed as talloc contexts. That will no longer generate a
warning.

also changed the talloc leak reporting option from --leak-check to
--leak-report, as all it does is generate a report on exit. A new
--leak-report-full option has been added that shows the complete tree
of memory allocations, which is is quite useful in tracking things down.

NOTE: I find it quite useful to insert talloc_report_full(ptr, stderr)
calls at strategic points in the code while debugging memory
allocation problems, particularly before freeing a major context (such
as the connection context). This allows you to see if that context has
been accumulating too much data, such as per-request data, which
should have been freed when the request finished.
(This used to be commit c60ff99c3129c26a9204bac1c6e5fb386114a923)

1 files changed, 1 insertions, 0 deletions

diff --git a/source4/include/talloc.h b/source4/include/talloc.h
index 635f77d043..4c108d865d 100644
--- a/source4/include/talloc.h
+++ b/source4/include/talloc.h
@@ -47,6 +47,7 @@ typedef void TALLOC_CTX;
 #define realloc_p(p, type, count) (type *)realloc_array(p, sizeof(type), count)
 
 #define data_blob(ptr, size) data_blob_named(ptr, size, __location__)
+#define data_blob_talloc(ctx, ptr, size) data_blob_talloc_named(ctx, ptr, size, __location__)
 
 #endif