* the RPC-ECHO pipe now works in smbd, as long as the data sizes

   don't cause fragmented pdus (I'll add fragments shortly)

 * change data_blob_talloc() to not zero memory when the 2nd argument
   is NULL. The zeroing just masks bugs, and can't even allow a DOS
   attack

 * modified pidl to ensure that [ref] arguments to the out side of
   functions are allocated when parsing the in side. This allows rpc
   backends to assume that [ref] variables are all setup. Doesn't work
   correctly for [ref] arrays yet

 * changed DLIST_ADD_END() to take the type instead of a tmp
   variable. This means you don't need to declare a silly tmp variable in
   the caller
(This used to be commit 46e0a358198eeb9af1907ee2a29025d3ab23b6d1)

1 files changed, 1 insertions, 1 deletions

diff --git a/source4/lib/data_blob.c b/source4/lib/data_blob.c
index 933617e9ee..457ad382a2 100644
--- a/source4/lib/data_blob.c
+++ b/source4/lib/data_blob.c
@@ -67,12 +67,12 @@ DATA_BLOB data_blob_talloc(TALLOC_CTX *mem_ctx, const void *p, size_t length)
 	}
 
 	if (p == NULL) {
+		/* note that we do NOT zero memory in this case */
 		ret.data = talloc(mem_ctx, length);
 		if (ret.data == NULL) {
 			smb_panic("data_blob_talloc: talloc_memdup failed.\n");
 		}
 		ret.length = length;
-		memset(ret.data, 0, ret.length);
 		ret.free = NULL;
 		return ret;
 	}