diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2008-10-27 13:32:23 +1100 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2008-11-04 16:06:56 +1100 |
| commit | 9381a78c391bcccd5eddc159a5d3a3e12d19fde3 (patch) | |
| tree | 81d9b89532c4e6019e3417b864f68b127fbb71ac /source4/lib/ldb/common/attrib_handlers.c | |
| parent | adf016e11946a354a140b1c0ed7789160e3af2aa (diff) | |
| download | samba-9381a78c391bcccd5eddc159a5d3a3e12d19fde3.tar.gz samba-9381a78c391bcccd5eddc159a5d3a3e12d19fde3.tar.bz2 samba-9381a78c391bcccd5eddc159a5d3a3e12d19fde3.zip | |
Use ldb_dn_from_ldb_val to avoid possible over-run of the value.
The ldb_val is length-limited, and while normally NULL terminated,
this avoids the chance that this particular value might not be, as
well as avoiding a cast.
Andrew Bartlett
Diffstat (limited to 'source4/lib/ldb/common/attrib_handlers.c')
| -rw-r--r-- | source4/lib/ldb/common/attrib_handlers.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/source4/lib/ldb/common/attrib_handlers.c b/source4/lib/ldb/common/attrib_handlers.c index fb57e2dadc..5ec86b5b8f 100644 --- a/source4/lib/ldb/common/attrib_handlers.c +++ b/source4/lib/ldb/common/attrib_handlers.c @@ -240,7 +240,7 @@ int ldb_canonicalise_dn(struct ldb_context *ldb, void *mem_ctx, out->length = 0; out->data = NULL; - dn = ldb_dn_new(ldb, mem_ctx, (char *)in->data); + dn = ldb_dn_from_ldb_val(ldb, mem_ctx, in); if ( ! ldb_dn_validate(dn)) { return LDB_ERR_INVALID_DN_SYNTAX; } @@ -268,10 +268,10 @@ int ldb_comparison_dn(struct ldb_context *ldb, void *mem_ctx, struct ldb_dn *dn1 = NULL, *dn2 = NULL; int ret; - dn1 = ldb_dn_new(ldb, mem_ctx, (char *)v1->data); + dn1 = ldb_dn_from_ldb_val(ldb, mem_ctx, v1); if ( ! ldb_dn_validate(dn1)) return -1; - dn2 = ldb_dn_new(ldb, mem_ctx, (char *)v2->data); + dn2 = ldb_dn_from_ldb_val(ldb, mem_ctx, v2); if ( ! ldb_dn_validate(dn2)) { talloc_free(dn1); return -1; |