diff options
| author | Matthias Dieter Wallnöfer <mdw@samba.org> | 2011-03-04 10:49:47 +0100 |
|---|---|---|
| committer | Matthias Dieter Wallnöfer <mdw@samba.org> | 2011-03-04 22:07:24 +0100 |
| commit | ea12adf544ffaf86a7b323c60c7f9dfbede87808 (patch) | |
| tree | 2e2c317f24fee761b89afdd6fc4bf0ff81218834 /source4/lib/ldb/tools/ldbrename.c | |
| parent | 349b9b72ec36194a1275eaa42ca145071256b623 (diff) | |
| download | samba-ea12adf544ffaf86a7b323c60c7f9dfbede87808.tar.gz samba-ea12adf544ffaf86a7b323c60c7f9dfbede87808.tar.bz2 samba-ea12adf544ffaf86a7b323c60c7f9dfbede87808.zip | |
s4/ldb - remove now superflous "ldb_dn_validate" checks
If we immediately afterwards perform an LDB base operation then we don't
need an explicit "ldb_dn_validate" check anymore (only OOM makes sense).
Reviewed by: Tridge
Diffstat (limited to 'source4/lib/ldb/tools/ldbrename.c')
| -rw-r--r-- | source4/lib/ldb/tools/ldbrename.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/source4/lib/ldb/tools/ldbrename.c b/source4/lib/ldb/tools/ldbrename.c index e8f67500fc..9bbd1f06b1 100644 --- a/source4/lib/ldb/tools/ldbrename.c +++ b/source4/lib/ldb/tools/ldbrename.c @@ -66,9 +66,8 @@ int main(int argc, const char **argv) dn1 = ldb_dn_new(ldb, ldb, options->argv[0]); dn2 = ldb_dn_new(ldb, ldb, options->argv[1]); - if ((!ldb_dn_validate(dn1)) || (!ldb_dn_validate(dn2))) { - printf("Invalid DN format(s)\n"); - return LDB_ERR_INVALID_DN_SYNTAX; + if ((dn1 == NULL) || (dn2 == NULL)) { + return LDB_ERR_OPERATIONS_ERROR; } ret = ldb_rename(ldb, dn1, dn2); |