diff options
| author | Michael Adam <obnox@samba.org> | 2008-03-18 12:16:47 +0100 |
|---|---|---|
| committer | Michael Adam <obnox@samba.org> | 2008-03-18 16:30:15 +0100 |
| commit | 87b48a812683794935db950446e9fb1db8e3da48 (patch) | |
| tree | 8378c52e0980ec6fa1787f58811d68304e262adf /source4/lib/replace/replace.c | |
| parent | 58dfb0ff3cb9a75e8caad89819f586b64df05f8a (diff) | |
| download | samba-87b48a812683794935db950446e9fb1db8e3da48.tar.gz samba-87b48a812683794935db950446e9fb1db8e3da48.tar.bz2 samba-87b48a812683794935db950446e9fb1db8e3da48.zip | |
libreplace: replace inet_ntoa() when it is missing
...not only replace it when it is broken.
This moves the defintion of rep_inet_ntoa from replace.c
to inet_ntoa.c and adds configure checks for existence
of inet_ntoa(). Checks are moved to an include file of its own.
NOTE: The original rep_inet_ntoa in replace.c was wrapped
into a "#ifndef WITH_PTHREADS" but the prototype in replace.h
and the define in system/network.h were not. I removed that
ifndef since the inet_ntoa() function is usually not thread safe
anyways, since it returns a pointer to a static buffer.
So whoever calls inet_ntoa() should be aware that it is not
thread safe anyways.
Michael
(This used to be commit 974c0c45ad42644348e0b55454715b12158f1028)
Diffstat (limited to 'source4/lib/replace/replace.c')
| -rw-r--r-- | source4/lib/replace/replace.c | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/source4/lib/replace/replace.c b/source4/lib/replace/replace.c index b2a240e8ab..c16bded963 100644 --- a/source4/lib/replace/replace.c +++ b/source4/lib/replace/replace.c @@ -295,20 +295,6 @@ char *rep_strdup(const char *s) } #endif /* HAVE_STRDUP */ -#ifndef WITH_PTHREADS -/* REWRITE: not thread safe */ -#ifdef REPLACE_INET_NTOA -char *rep_inet_ntoa(struct in_addr ip) -{ - uint8_t *p = (uint8_t *)&ip.s_addr; - static char buf[18]; - slprintf(buf, 17, "%d.%d.%d.%d", - (int)p[0], (int)p[1], (int)p[2], (int)p[3]); - return buf; -} -#endif /* REPLACE_INET_NTOA */ -#endif - #ifndef HAVE_SETLINEBUF void rep_setlinebuf(FILE *stream) { |