diff options
| author | Andrew Tridgell <tridge@samba.org> | 2005-10-11 05:01:52 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 13:39:40 -0500 |
| commit | 5d1bc4fe31192503621cce704d24c0c5e11d24fc (patch) | |
| tree | 6d7485adb90234f373a9f0db0f972b6313228ef1 /source4/lib/tdb | |
| parent | a3b33d6fa811dd1277e51e17ba4a4c3954457397 (diff) | |
| download | samba-5d1bc4fe31192503621cce704d24c0c5e11d24fc.tar.gz samba-5d1bc4fe31192503621cce704d24c0c5e11d24fc.tar.bz2 samba-5d1bc4fe31192503621cce704d24c0c5e11d24fc.zip | |
r10891: I noticed that the secrets.db was not being backed up on my system due
to msync/mmap not changing the mtime of the file. This patch ensures
that for successfully completed transactions we update the mtime.
I don't do this on all tdb writes as its too expensive, but doing it
just on transactions is bearable, as those cost quite a lot anyway.
(This used to be commit b2934732dd62f705f59c124f19460c5436a9a422)
Diffstat (limited to 'source4/lib/tdb')
| -rw-r--r-- | source4/lib/tdb/common/transaction.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/source4/lib/tdb/common/transaction.c b/source4/lib/tdb/common/transaction.c index 9d37046116..becc6cd059 100644 --- a/source4/lib/tdb/common/transaction.c +++ b/source4/lib/tdb/common/transaction.c @@ -857,6 +857,15 @@ int tdb_transaction_commit(struct tdb_context *tdb) tdb_brlock_len(tdb, GLOBAL_LOCK, F_UNLCK, F_SETLKW, 0, 1); + /* on some systems (like Linux 2.6.x) changes via mmap/msync + don't change the mtime of the file, this means the file may + not be backed up (as tdb rounding to block sizes means that + file size changes are quite rare too). The following forces + mtime changes when a transaction completes */ +#ifdef HAVE_UTIME + utime(tdb->name, NULL); +#endif + /* use a transaction cancel to free memory and remove the transaction locks */ tdb_transaction_cancel(tdb); |