r6271: Don't zero the cli_credentials structure - instead allow valgrind to

track the use of un-initialised values.

This change will require a recompile from clean, as the enum
describing the status of each element now has a default of
CRED_UNINITIALISED.

Andrew Bartlett
(This used to be commit 83c2eb806d43f588bd06336aa7e2dbdc00dc2c67)

1 files changed, 7 insertions, 1 deletions

diff --git a/source4/lib/credentials.c b/source4/lib/credentials.c
index 9c892b0688..ba263260bb 100644
--- a/source4/lib/credentials.c
+++ b/source4/lib/credentials.c
@@ -32,11 +32,17 @@
  */
 struct cli_credentials *cli_credentials_init(TALLOC_CTX *mem_ctx) 
 {
-	struct cli_credentials *cred = talloc_zero(mem_ctx, struct cli_credentials);
+	struct cli_credentials *cred = talloc(mem_ctx, struct cli_credentials);
 	if (!cred) {
 		return cred;
 	}
 
+	cred->machine_account_pending = False;
+	cred->workstation_obtained = CRED_UNINITIALISED;
+	cred->username_obtained = CRED_UNINITIALISED;
+	cred->password_obtained = CRED_UNINITIALISED;
+	cred->domain_obtained = CRED_UNINITIALISED;
+	cred->realm_obtained = CRED_UNINITIALISED;
 	return cred;
 }