r2900: rusty pointed out to me that discard_const() can be done via a macro

on systems that have the intptr_t type, and for systems that don't
have it, they also almost certainly won't have -Wcast-qual, so we can use a
void* cast.
(This used to be commit 2132d38f9c5ba59825558d5ba084a514ebc2626b)

1 files changed, 0 insertions, 22 deletions

diff --git a/source4/lib/util.c b/source4/lib/util.c
index 94b01f7501..fde5390127 100644
--- a/source4/lib/util.c
+++ b/source4/lib/util.c
@@ -892,25 +892,3 @@ BOOL all_zero(const char *ptr, uint_t size)
 }
 
 
-/*
-  this is a warning hack. The idea is to use this everywhere that we
-  get the "discarding const" warning from gcc, effectively moving all
-  the warnings to this one place. That doesn't actually fix the
-  problem of course, but it means that when we do get to cleaning them
-  up we can do it by searching the code for discard_const.
-
-  It also means that other error types aren't as swamped by the noise
-  of hundreds of const warnings, so we are more likely to notice when
-  we get new errors.
-
-  Please only add more calls to this function when you find it
-  _really_ hard to fix const warnings. Our aim is to eventually use
-  this function in only a very few places.
-
-  Also, please call this via the discard_const_p() macro interface, as that
-  makes the return type safe.
-*/
-void *discard_const(const void *ptr)
-{
-	return (void *)ptr;
-}