diff options
| author | Andrew Tridgell <tridge@samba.org> | 2005-07-09 01:53:57 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 13:19:25 -0500 |
| commit | bde98850be7d7868c59597012e3366cf14fd0169 (patch) | |
| tree | 718fd0bcb4357c68b690acf3feb541c349bbe2c6 /source4/libcli/nbt | |
| parent | 5c87688051bc898e4a606f5ce1654eed0c3bb5d7 (diff) | |
| download | samba-bde98850be7d7868c59597012e3366cf14fd0169.tar.gz samba-bde98850be7d7868c59597012e3366cf14fd0169.tar.bz2 samba-bde98850be7d7868c59597012e3366cf14fd0169.zip | |
r8247: remove the free of fullname in nbtname.c for now.
Metze, the ndr_token_store() code is storing temporary pointers into
this string in the token list, which means we are referring to freed
memory when we scan the token list. A better key might be a pointer
into the ndr buffer?
(This used to be commit 6a4e8cc991613773a65545eb308cf4ead75844e8)
Diffstat (limited to 'source4/libcli/nbt')
| -rw-r--r-- | source4/libcli/nbt/nbtname.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/source4/libcli/nbt/nbtname.c b/source4/libcli/nbt/nbtname.c index 205567a55b..b59c24e7cf 100644 --- a/source4/libcli/nbt/nbtname.c +++ b/source4/libcli/nbt/nbtname.c @@ -343,8 +343,12 @@ NTSTATUS ndr_push_nbt_name(struct ndr_push *ndr, int ndr_flags, const struct nbt } status = ndr_push_nbt_string(ndr, ndr_flags, fullname); +#if 0 + /* this free conflicts with the use of pointers into strings + in the ndr_token_store() calls above. Metze, can you look + at this? */ talloc_free(fullname); - +#endif return status; } |