r5661: Be a little stricter on syntax regarding arrays. A pointer to an

array can now only be :

 type *name[];

rather then :

 type *name;

which was supported in the past. Warnings will be given when the first
syntax is used. Reasons for this change in behaviour include improved
readability and the fact that the second format makes dealing with multiple
levels of pointers harder.
(This used to be commit a416de5825c540fd3741731c4be05e9a659a6fdb)

1 files changed, 18 insertions, 18 deletions

diff --git a/source4/librpc/idl/lsa.idl b/source4/librpc/idl/lsa.idl
index 5d291927dd..8b20b6db90 100644
--- a/source4/librpc/idl/lsa.idl
+++ b/source4/librpc/idl/lsa.idl
@@ -47,7 +47,7 @@
 
 	typedef struct {
 		uint32 count;
-		[size_is(count)] lsa_PrivEntry *privs;
+		[size_is(count)] lsa_PrivEntry *privs[];
 	} lsa_PrivArray;
 
 	NTSTATUS lsa_EnumPrivs (
@@ -121,7 +121,7 @@
 
 	typedef struct {
 		uint32 auditing_mode;
-		[size_is(count)] uint32 *settings;
+		[size_is(count)] uint32 *settings[];
 		uint32 count;
 	} lsa_AuditEventsInfo;
 
@@ -240,7 +240,7 @@
 	
 	typedef [public] struct {
 		[range(0,1000)] uint32 num_sids;
-		[size_is(num_sids)] lsa_SidPtr *sids;
+		[size_is(num_sids)] lsa_SidPtr *sids[];
 	} lsa_SidArray;
 
 	NTSTATUS lsa_EnumAccounts (
@@ -280,7 +280,7 @@
 
 	typedef struct {
 		uint32 count;
-		[size_is(count)] lsa_DomainInformation *domains;
+		[size_is(count)] lsa_DomainInformation *domains[];
 	} lsa_DomainList;
 
 	NTSTATUS lsa_EnumTrustDom (
@@ -313,19 +313,19 @@
 
 	typedef struct {
 		[range(0,1000)] uint32 count;
-		[size_is(count)] lsa_TranslatedSid *sids;
+		[size_is(count)] lsa_TranslatedSid *sids[];
 	} lsa_TransSidArray;
 
 	typedef struct {
 		[range(0,1000)] uint32 count;
-		[size_is(count)] lsa_TrustInformation *domains;
+		[size_is(count)] lsa_TrustInformation *domains[];
 		uint32 max_count;
 	} lsa_RefDomainList;
 
 	NTSTATUS lsa_LookupNames (
 		[in,ref]     policy_handle *handle,
 		[in,range(0,1000)] uint32 num_names,
-		[in,ref,size_is(num_names)]  lsa_String *names,
+		[in,size_is(num_names)]  lsa_String names[],
 		[out]        lsa_RefDomainList *domains,
 		[in,out,ref] lsa_TransSidArray *sids,
 		[in]         uint16 level,
@@ -344,7 +344,7 @@
 
 	typedef struct {
 		[range(0,1000)] uint32 count;
-		[size_is(count)] lsa_TranslatedName *names;
+		[size_is(count)] lsa_TranslatedName *names[];
 	} lsa_TransNameArray;
 
 	NTSTATUS lsa_LookupSids (
@@ -434,12 +434,12 @@
 	typedef [flag(NDR_PAHEX)] struct {
 		uint32 length;
 		uint32 size;
-		[size_is(size),length_is(length)] uint8 *data;
+		[size_is(size),length_is(length)] uint8 *data[];
 	} lsa_DATA_BUF;
 
 	typedef [flag(NDR_PAHEX)] struct {
 		[range(0,65536)] uint32 size;
-		[size_is(size)] uint8 *data;
+		[size_is(size)] uint8 *data[];
 	} lsa_DATA_BUF2;
 
 	typedef enum {
@@ -613,7 +613,7 @@
 	
 	typedef struct {
 		uint32 count;
-		[size_is(count)] lsa_String *names;
+		[size_is(count)] lsa_String *names[];
 	} lsa_RightSet;
 	
 	NTSTATUS lsa_EnumAccountRights (
@@ -644,7 +644,7 @@
 	NTSTATUS lsa_QueryTrustedDomainInfoBySid(
 		[in,ref]               policy_handle         *handle,
 		[in,ref]               dom_sid2              *dom_sid,
-		[in]                   uint16                 level, 
+		[in]                   lsa_TrustDomInfoEnum  level, 
 		[out,switch_is(level)] lsa_TrustedDomainInfo *info
         );
 
@@ -696,7 +696,7 @@
 	NTSTATUS lsa_QueryTrustedDomainInfoByName(
 		[in,ref]               policy_handle         *handle,
 		[in]                   lsa_String             trusted_domain,
-		[in]                   uint16                 level, 
+		[in]                   lsa_TrustDomInfoEnum   level, 
 		[out,switch_is(level)] lsa_TrustedDomainInfo *info
 		);
 
@@ -742,7 +742,7 @@
 
 	typedef struct {
 		[range(0,1000)] uint32 count;
-		[size_is(count)] lsa_TranslatedName2 *names;
+		[size_is(count)] lsa_TranslatedName2 *names[];
 	} lsa_TransNameArray2;
 
 	NTSTATUS lsa_LookupSids2(
@@ -768,13 +768,13 @@
 
 	typedef struct {
 		[range(0,1000)] uint32 count;
-		[size_is(count)] lsa_TranslatedSid2 *sids;
+		[size_is(count)] lsa_TranslatedSid2 *sids[];
 	} lsa_TransSidArray2;
 
 	NTSTATUS lsa_LookupNames2 (
 		[in,ref]     policy_handle *handle,
 		[in,range(0,1000)] uint32 num_names,
-		[in,ref,size_is(num_names)]  lsa_String *names,
+		[in,size_is(num_names)]  lsa_String names[],
 		[out]        lsa_RefDomainList *domains,
 		[in,out,ref] lsa_TransSidArray2 *sids,
 		[in]         uint16 level,
@@ -821,13 +821,13 @@
 
 	typedef struct {
 		[range(0,1000)] uint32 count;
-		[size_is(count)] lsa_TranslatedSid3 *sids;
+		[size_is(count)] lsa_TranslatedSid3 *sids[];
 	} lsa_TransSidArray3;
 
 	NTSTATUS lsa_LookupNames3 (
 		[in,ref]     policy_handle *handle,
 		[in,range(0,1000)] uint32 num_names,
-		[in,ref,size_is(num_names)]  lsa_String *names,
+		[in,size_is(num_names)]  lsa_String names[],
 		[out]        lsa_RefDomainList *domains,
 		[in,out,ref] lsa_TransSidArray3 *sids,
 		[in]         uint16 level,