summaryrefslogtreecommitdiff
path: root/source4/librpc
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2007-11-05 07:09:41 +0100
committerStefan Metzmacher <metze@samba.org>2007-12-21 05:44:16 +0100
commitc559f0057f830898a20851ee4a3a28ebfcd8e264 (patch)
tree5f078da060f4b68d909ddd79954189ce66e9aecf /source4/librpc
parenta1ce0635ec70960fe92d13887a95a3d04aecd74d (diff)
downloadsamba-c559f0057f830898a20851ee4a3a28ebfcd8e264.tar.gz
samba-c559f0057f830898a20851ee4a3a28ebfcd8e264.tar.bz2
samba-c559f0057f830898a20851ee4a3a28ebfcd8e264.zip
r25829: - use DEBUG() instead of printf
- return an error if strings doesn't match on validate metze (This used to be commit 4f5ad8cd447f8b44df1bd40f5ee3045d5ab2c3dc)
Diffstat (limited to 'source4/librpc')
-rw-r--r--source4/librpc/rpc/dcerpc.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/source4/librpc/rpc/dcerpc.c b/source4/librpc/rpc/dcerpc.c
index 5f7b2991a9..9d58fafcb8 100644
--- a/source4/librpc/rpc/dcerpc.c
+++ b/source4/librpc/rpc/dcerpc.c
@@ -1291,7 +1291,7 @@ static NTSTATUS dcerpc_ndr_validate_out(struct dcerpc_connection *c,
NDR_OUT, st);
if (strcmp(s1, s2) != 0) {
#if 1
- printf("VALIDATE ERROR:\nWIRE:\n%s\n GEN:\n%s\n", s1, s2);
+ DEBUG(3,("VALIDATE ERROR:\nWIRE:\n%s\n GEN:\n%s\n", s1, s2));
#else
/* this is sometimes useful */
printf("VALIDATE ERROR\n");
@@ -1299,6 +1299,8 @@ static NTSTATUS dcerpc_ndr_validate_out(struct dcerpc_connection *c,
file_save("gen.dat", s2, strlen(s2));
system("diff -u wire.dat gen.dat");
#endif
+ return ndr_push_error(push, NDR_ERR_VALIDATE,
+ "failed output validation strings doesn't match");
}
return NT_STATUS_OK;