r7860: switch our ldb storage format to use a NDR encoded objectSid. This is

quite a large change as we had lots of code that assumed that
objectSid was a string in S- format.

metze and simo tried to convince me to use NDR format months ago, but
I didn't listen, so its fair that I have the pain of fixing all the
code now :-)

This builds on the ldb_register_samba_handlers() and ldif handlers
code I did earlier this week. There are still three parts of this
conversion I have not finished:

 - the ltdb index records need to use the string form of the objectSid
   (to keep the DNs sane). Until that it done I have disabled indexing on
   objectSid, which is a big performance hit, but allows us to pass
   all our tests while I rejig the indexing system to use a externally
   supplied conversion function

 - I haven't yet put in place the code that allows client to use the
   "S-xxx-yyy" form for objectSid in ldap search expressions. w2k3
   supports this, presumably by looking for the "S-" prefix to
   determine what type of objectSid form is being used by the client. I
   have been working on ways to handle this, but am not happy with
   them yet so they aren't part of this patch

 - I need to change pidl to generate push functions that take a
   "const void *" instead of a "void*" for the data pointer. That will
   fix the couple of new warnings this code generates.

Luckily it many places the conversion to NDR formatted records
actually simplified the code, as it means we no longer need as many
calls to dom_sid_parse_talloc(). In some places it got more complex,
but not many.
(This used to be commit d40bc2fa8ddd43560315688eebdbe98bdd02756c)

1 files changed, 9 insertions, 8 deletions

diff --git a/source4/rpc_server/netlogon/dcerpc_netlogon.c b/source4/rpc_server/netlogon/dcerpc_netlogon.c
index bd20deedb9..4dd8312df5 100644
--- a/source4/rpc_server/netlogon/dcerpc_netlogon.c
+++ b/source4/rpc_server/netlogon/dcerpc_netlogon.c
@@ -313,7 +313,7 @@ static NTSTATUS netr_ServerPasswordSet(struct dcesrv_call_state *dce_call, TALLO
 	struct ldb_message **msgs_domain;
 	NTSTATUS nt_status;
 	struct ldb_message *mod;
-	const char *domain_sid;
+	struct dom_sid *domain_sid;
 
 	const char *attrs[] = {"objectSid", NULL };
 
@@ -356,20 +356,20 @@ static NTSTATUS netr_ServerPasswordSet(struct dcesrv_call_state *dce_call, TALLO
 	num_records_domain = gendb_search(sam_ctx, mem_ctx, NULL, 
 					  &msgs_domain, domain_attrs,
 					  "(&(objectSid=%s)(objectclass=domain))", 
-					  domain_sid);
+					  ldap_encode_ndr_dom_sid(mem_ctx, domain_sid));
 	if (num_records_domain == -1) {
 		return NT_STATUS_INTERNAL_DB_CORRUPTION;
 	}
 
 	if (num_records_domain == 0) {
 		DEBUG(3,("Couldn't find domain [%s] in samdb.\n", 
-			 domain_sid));
+			 dom_sid_string(mem_ctx, domain_sid)));
 		return NT_STATUS_NO_SUCH_USER;
 	}
 
 	if (num_records_domain > 1) {
 		DEBUG(0,("Found %d records matching domain [%s]\n", 
-			 num_records_domain, domain_sid));
+			 num_records_domain, dom_sid_string(mem_ctx, domain_sid)));
 		return NT_STATUS_INTERNAL_DB_CORRUPTION;
 	}
 
@@ -1036,7 +1036,7 @@ static NTSTATUS netr_ServerPasswordSet2(struct dcesrv_call_state *dce_call, TALL
 	struct ldb_message **msgs_domain;
 	NTSTATUS nt_status;
 	struct ldb_message *mod;
-	const char *domain_sid;
+	struct dom_sid *domain_sid;
 	char new_pass[512];
 	uint32_t new_pass_len;
 
@@ -1083,20 +1083,21 @@ static NTSTATUS netr_ServerPasswordSet2(struct dcesrv_call_state *dce_call, TALL
 	num_records_domain = gendb_search(sam_ctx, mem_ctx, NULL, 
 					  &msgs_domain, domain_attrs,
 					  "(&(objectSid=%s)(objectclass=domain))", 
-					  domain_sid);
+					  ldap_encode_ndr_dom_sid(mem_ctx, domain_sid));
 	if (num_records_domain == -1) {
 		return NT_STATUS_INTERNAL_DB_CORRUPTION;
 	}
 
 	if (num_records_domain == 0) {
 		DEBUG(3,("Couldn't find domain [%s] in samdb.\n", 
-			 domain_sid));
+			 ldap_encode_ndr_dom_sid(mem_ctx, domain_sid)));
 		return NT_STATUS_NO_SUCH_USER;
 	}
 
 	if (num_records_domain > 1) {
 		DEBUG(0,("Found %d records matching domain [%s]\n", 
-			 num_records_domain, domain_sid));
+			 num_records_domain, 
+			 ldap_encode_ndr_dom_sid(mem_ctx, domain_sid)));
 		return NT_STATUS_INTERNAL_DB_CORRUPTION;
 	}