summaryrefslogtreecommitdiff
path: root/source4/rpc_server
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2010-10-23 11:01:43 +0200
committerStefan Metzmacher <metze@samba.org>2010-10-23 11:01:43 +0200
commitc2696b2ec37815a1bc0594295b6fe81b3e156c11 (patch)
treeb1649450c875e547a45de67a8f5aad40fc1592e3 /source4/rpc_server
parent5ee49fc1c1afe7a0d4cc2ae6bfe44c21dd1fdb83 (diff)
downloadsamba-c2696b2ec37815a1bc0594295b6fe81b3e156c11.tar.gz
samba-c2696b2ec37815a1bc0594295b6fe81b3e156c11.tar.bz2
samba-c2696b2ec37815a1bc0594295b6fe81b3e156c11.zip
s4:rpc_server/netlogon: netr_ServerAuthenticate3 should check the challenge after the account
metze
Diffstat (limited to 'source4/rpc_server')
-rw-r--r--source4/rpc_server/netlogon/dcerpc_netlogon.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/source4/rpc_server/netlogon/dcerpc_netlogon.c b/source4/rpc_server/netlogon/dcerpc_netlogon.c
index b4c58e3bab..0f4d7465b5 100644
--- a/source4/rpc_server/netlogon/dcerpc_netlogon.c
+++ b/source4/rpc_server/netlogon/dcerpc_netlogon.c
@@ -125,11 +125,6 @@ static NTSTATUS dcesrv_netr_ServerAuthenticate3(struct dcesrv_call_state *dce_ca
NETLOGON_NEG_AUTHENTICATED_RPC_LSASS |
NETLOGON_NEG_AUTHENTICATED_RPC;
- if (!pipe_state) {
- DEBUG(1, ("No challenge requested by client, cannot authenticate\n"));
- return NT_STATUS_ACCESS_DENIED;
- }
-
sam_ctx = samdb_connect(mem_ctx, dce_call->event_ctx, dce_call->conn->dce_ctx->lp_ctx,
system_session(dce_call->conn->dce_ctx->lp_ctx), 0);
if (sam_ctx == NULL) {
@@ -239,6 +234,11 @@ static NTSTATUS dcesrv_netr_ServerAuthenticate3(struct dcesrv_call_state *dce_ca
return NT_STATUS_ACCESS_DENIED;
}
+ if (!pipe_state) {
+ DEBUG(1, ("No challenge requested by client, cannot authenticate\n"));
+ return NT_STATUS_ACCESS_DENIED;
+ }
+
creds = netlogon_creds_server_init(mem_ctx,
r->in.account_name,
r->in.computer_name,