diff options
author | Andrew Bartlett <abartlet@samba.org> | 2007-04-11 03:45:39 +0000 |
---|---|---|
committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 14:49:55 -0500 |
commit | 7b88696bed9dac1a40e31f360a8781910636455a (patch) | |
tree | e33928f9bc2eb2f682ef6b65b6792793912b88cc /source4/script/tests/Samba3.pm | |
parent | dbfb32ffe5925259994712c9b1f18c4b60b9cdee (diff) | |
download | samba-7b88696bed9dac1a40e31f360a8781910636455a.tar.gz samba-7b88696bed9dac1a40e31f360a8781910636455a.tar.bz2 samba-7b88696bed9dac1a40e31f360a8781910636455a.zip |
r22161: Clarify exactly where the socket_wrapper should be handled (early),
and ensure that $prefix exists before it tries to create $prefix/w.
This should fix the build farm. Perhaps we should have a rm -rf
$prefix at the start of this script, as that would have found the
problem, but I want to be careful about that...
Andrew Bartlett
(This used to be commit a230261e83fd9161e60554b74cf8556f36b1af45)
Diffstat (limited to 'source4/script/tests/Samba3.pm')
-rw-r--r-- | source4/script/tests/Samba3.pm | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/source4/script/tests/Samba3.pm b/source4/script/tests/Samba3.pm index 83604f29ab..950f7e3479 100644 --- a/source4/script/tests/Samba3.pm +++ b/source4/script/tests/Samba3.pm @@ -16,14 +16,11 @@ sub new($$$) { return $self; } -sub check_or_start($$$$) +sub check_or_start($$$) { - my ($self, $env_vars, $socket_wrapper_dir, $max_time) = @_; + my ($self, $env_vars, $max_time) = @_; return 0 if ( -p $env_vars->{SMBD_TEST_FIFO}); - warn("Not using socket wrapper, but also not running as root. Will not be able to listen on proper ports") unless - defined($socket_wrapper_dir) or $< == 0; - unlink($env_vars->{SMBD_TEST_FIFO}); POSIX::mkfifo($env_vars->{SMBD_TEST_FIFO}, 0700); unlink($env_vars->{SMBD_TEST_LOG}); @@ -49,7 +46,6 @@ sub check_or_start($$$$) exit 1; } unlink($env_vars->{SMBD_TEST_FIFO}); - unlink(<$socket_wrapper_dir/*>) if (defined($socket_wrapper_dir) and -d $socket_wrapper_dir); my $exit = $? >> 8; if ( $ret == 0 ) { print "smbd exits with status $exit\n"; @@ -121,9 +117,9 @@ sub stop($) return $failed; } -sub setup_env($$$) +sub setup_env($$) { - my ($self, $name, $socket_wrapper_dir) = @_; + my ($self, $name) = @_; } 1; |