summaryrefslogtreecommitdiff
path: root/source4/scripting
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2005-08-22 23:33:47 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 13:34:21 -0500
commitda6dc01ae2c7bc26a14af2189d345e0ec38a9660 (patch)
treeedb4c17a9bcf71f0a1447e5da4d0886721deb992 /source4/scripting
parentfef7a81478cb246a7d2fe29283a50d52501ccc33 (diff)
downloadsamba-da6dc01ae2c7bc26a14af2189d345e0ec38a9660.tar.gz
samba-da6dc01ae2c7bc26a14af2189d345e0ec38a9660.tar.bz2
samba-da6dc01ae2c7bc26a14af2189d345e0ec38a9660.zip
r9492: it is more usual to return 'undefined' instead of 'false' on a call failing (unless the
call is returning a boolean anyway). Unfortunately the new GetOptions syntax loses the ability for the caller to know why the command line arguments were bad. Maybe we would be better always returning an object and having an is_error element? (This used to be commit 516ba6d20bd1bd8d0235028515e94a8c4fd6574d)
Diffstat (limited to 'source4/scripting')
-rw-r--r--source4/scripting/ejs/smbcalls_options.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source4/scripting/ejs/smbcalls_options.c b/source4/scripting/ejs/smbcalls_options.c
index 8eca9ebcaa..3ba51bb2f4 100644
--- a/source4/scripting/ejs/smbcalls_options.c
+++ b/source4/scripting/ejs/smbcalls_options.c
@@ -156,7 +156,7 @@ static int ejs_GetOptions(MprVarHandle eid, int argc, struct MprVar **argv)
poptStrerror(opt));
mprSetVar(options, "ERROR", mprString(err));
talloc_free(tmp_ctx);
- mpr_Return(eid, mprCreateBoolVar(0));
+ mpr_Return(eid, mprCreateUndefinedVar());
return 0;
}
opt -= BASE_OPTNUM;