summaryrefslogtreecommitdiff
path: root/source4/selftest/output
diff options
context:
space:
mode:
authorJelmer Vernooij <jelmer@samba.org>2008-04-16 00:03:45 +0200
committerJelmer Vernooij <jelmer@samba.org>2008-04-16 00:03:45 +0200
commit8eb6d59a466cf7d9c79b1a271737873c8744ed16 (patch)
tree5e7506a4e806add411bbf92486e7de645eaadb04 /source4/selftest/output
parentd3729a8efa1c7e848d263ef320d3114144477be3 (diff)
downloadsamba-8eb6d59a466cf7d9c79b1a271737873c8744ed16.tar.gz
samba-8eb6d59a466cf7d9c79b1a271737873c8744ed16.tar.bz2
samba-8eb6d59a466cf7d9c79b1a271737873c8744ed16.zip
Properly warn about exit codes that indicate success while tests claim
failure. (This used to be commit 92873264d707bed88beac54a73a29d66c011f80c)
Diffstat (limited to 'source4/selftest/output')
-rw-r--r--source4/selftest/output/plain.pm3
1 files changed, 3 insertions, 0 deletions
diff --git a/source4/selftest/output/plain.pm b/source4/selftest/output/plain.pm
index 25ff74792e..f14e26b38d 100644
--- a/source4/selftest/output/plain.pm
+++ b/source4/selftest/output/plain.pm
@@ -81,6 +81,9 @@ sub end_testsuite($$$$$)
my $out = "";
if ($unexpected) {
+ if ($result eq "success" and not defined($reason)) {
+ $reason = "Expected negative exit code, got positive exit code";
+ }
$self->output_msg("ERROR: $reason\n");
push (@{$self->{suitesfailed}}, $name);
} else {