r5941: Commit this patch much earlier than I would normally prefer, but metze needs a working tree...

The main volume of this patch was what I started working on today:
 - Cleans up memory handling around DCE/RPC pipes, to have a parent talloc context.
 - Uses sepereate inner loops for some of the DCE/RPC tests

The other and more important part of this patch fixes issues
surrounding the new credentials framwork:

This makes the struct cli_credentials always a talloc() structure,
rather than on the stack.  Parts of the cli_credentials code already
assumed this.

There were other issues, particularly in the DCERPC over SMB handling,
as well as little things that had to be tidied up before test_w2k3.sh
would start to pass.

Andrew Bartlett
(This used to be commit 0453f9d05d2e336fba1f85dbf2718d01fa2bf778)

1 files changed, 3 insertions, 6 deletions

diff --git a/source4/torture/com/simple.c b/source4/torture/com/simple.c
index 128d84d1c7..25800896db 100644
--- a/source4/torture/com/simple.c
+++ b/source4/torture/com/simple.c
@@ -28,7 +28,6 @@
 
 static BOOL test_readwrite(TALLOC_CTX *mem_ctx, const char *host)
 {
-	struct dcerpc_pipe *p = NULL;
 	BOOL ret = True;
 	struct GUID IID[2];
 	struct GUID clsid;
@@ -48,9 +47,9 @@ static BOOL test_readwrite(TALLOC_CTX *mem_ctx, const char *host)
 
 	if (host) {
 		error = dcom_create_object(ctx, &clsid, 
-							  host, 2, IID,
-							  &interfaces, 
-							  results);
+					   host, 2, IID,
+					   &interfaces, 
+					   results);
 	} else {
 		error = com_create_object(ctx, &clsid, 2, IID, interfaces, results);
 	}
@@ -78,8 +77,6 @@ static BOOL test_readwrite(TALLOC_CTX *mem_ctx, const char *host)
 
 	IUnknown_Release((struct IUnknown *)interfaces[1], mem_ctx);
 
-	torture_rpc_close(p);
-
 	return True;
 }