diff options
author | Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de> | 2009-06-15 17:55:43 +0200 |
---|---|---|
committer | Andrew Bartlett <abartlet@samba.org> | 2009-06-18 13:49:26 +1000 |
commit | b250c8de3930ed95c876219e13ceb1375b07d228 (patch) | |
tree | d1120da2fafca96b639c5b5c2b70a0bda41df1cb /source4/torture/ldap/cldap.c | |
parent | ef45b31886bbe34856abba718448972b62b48d3e (diff) | |
download | samba-b250c8de3930ed95c876219e13ceb1375b07d228.tar.gz samba-b250c8de3930ed95c876219e13ceb1375b07d228.tar.bz2 samba-b250c8de3930ed95c876219e13ceb1375b07d228.zip |
Fixes for the "cldap" tests
- Insert a check after the "tsocket" library call to make sure that the call
terminated correctly
- Add a comment to explain why on further calls of "cldap_socket_init" the
destination address hasn't to be specified
Diffstat (limited to 'source4/torture/ldap/cldap.c')
-rw-r--r-- | source4/torture/ldap/cldap.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/source4/torture/ldap/cldap.c b/source4/torture/ldap/cldap.c index 814c9ac86d..d0e9719188 100644 --- a/source4/torture/ldap/cldap.c +++ b/source4/torture/ldap/cldap.c @@ -54,6 +54,7 @@ static bool test_cldap_netlogon(struct torture_context *tctx, const char *dest) dest, lp_cldap_port(tctx->lp_ctx), &dest_addr); + CHECK_VAL(ret, 0); status = cldap_socket_init(tctx, NULL, NULL, dest_addr, &cldap); CHECK_STATUS(status, NT_STATUS_OK); @@ -251,6 +252,7 @@ static bool test_cldap_netlogon_flags(struct torture_context *tctx, uint32_t server_type; struct smb_iconv_convenience *iconv_convenience = lp_iconv_convenience(tctx->lp_ctx); + /* cldap_socket_init should now know about the dest. address */ status = cldap_socket_init(tctx, NULL, NULL, NULL, &cldap); CHECK_STATUS(status, NT_STATUS_OK); @@ -361,9 +363,9 @@ static bool test_cldap_netlogon_flag_ds_dns_forest(struct torture_context *tctx, uint32_t server_type; struct netlogon_samlogon_response n1; struct smb_iconv_convenience *iconv_convenience = lp_iconv_convenience(tctx->lp_ctx); - bool result = true; + /* cldap_socket_init should now know about the dest. address */ status = cldap_socket_init(tctx, NULL, NULL, NULL, &cldap); CHECK_STATUS(status, NT_STATUS_OK); @@ -437,6 +439,7 @@ static bool test_cldap_generic(struct torture_context *tctx, const char *dest) const char *attrs2[] = { "currentTime", "highestCommittedUSN", "netlogon", NULL }; const char *attrs3[] = { "netlogon", NULL }; + /* cldap_socket_init should now know about the dest. address */ status = cldap_socket_init(tctx, NULL, NULL, NULL, &cldap); CHECK_STATUS(status, NT_STATUS_OK); |