r7633: this patch started as an attempt to make the dcerpc code use a given

event_context for the socket_connect() call, so that when things that
use dcerpc are running alongside anything else it doesn't block the
whole process during a connect.

Then of course I needed to change any code that created a dcerpc
connection (such as the auth code) to also take an event context, and
anything that called that and so on .... thus the size of the patch.

There were 3 places where I punted:

  - abartlet wanted me to add a gensec_set_event_context() call
    instead of adding it to the gensec init calls. Andrew, my
    apologies for not doing this. I didn't do it as adding a new
    parameter allowed me to catch all the callers with the
    compiler. Now that its done, we could go back and use
    gensec_set_event_context()

  - the ejs code calls auth initialisation, which means it should pass
    in the event context from the web server. I punted on that. Needs fixing.

  - I used a NULL event context in dcom_get_pipe(). This is equivalent
    to what we did already, but should be fixed to use a callers event
    context. Jelmer, can you think of a clean way to do that?

I also cleaned up a couple of things:

 - libnet_context_destroy() makes no sense. I removed it.

 - removed some unused vars in various places
(This used to be commit 3a3025485bdb8f600ab528c0b4b4eef0c65e3fc9)

1 files changed, 4 insertions, 4 deletions

diff --git a/source4/torture/torture.c b/source4/torture/torture.c
index a2ca9fc72f..c96f862142 100644
--- a/source4/torture/torture.c
+++ b/source4/torture/torture.c
@@ -82,7 +82,7 @@ BOOL torture_open_connection_share(struct smbcli_state **c,
 	status = smbcli_full_connection(NULL,
 					c, hostname, 
 					sharename, NULL,
-					cmdline_credentials);
+					cmdline_credentials, NULL);
 	if (!NT_STATUS_IS_OK(status)) {
 		printf("Failed to open connection - %s\n", nt_errstr(status));
 		return False;
@@ -133,7 +133,7 @@ NTSTATUS torture_rpc_connection(TALLOC_CTX *parent_ctx,
 
 	status = dcerpc_pipe_connect(parent_ctx, 
 				     p, binding, pipe_uuid, pipe_version,
-				     cmdline_credentials);
+				     cmdline_credentials, NULL);
  
         return status;
 }
@@ -167,7 +167,7 @@ NTSTATUS torture_rpc_connection_transport(TALLOC_CTX *parent_ctx,
 	b->transport = transport;
 
 	status = dcerpc_pipe_connect_b(mem_ctx, p, b, pipe_uuid, pipe_version,
-								   cmdline_credentials);
+				       cmdline_credentials, NULL);
 					   
 	if (NT_STATUS_IS_OK(status)) {
 		*p = talloc_reference(parent_ctx, *p);
@@ -612,7 +612,7 @@ static BOOL run_tcon_devtype_test(void)
 	status = smbcli_full_connection(NULL,
 					&cli1, host, 
 					share, NULL,
-					cmdline_credentials);
+					cmdline_credentials, NULL);
 
 	if (!NT_STATUS_IS_OK(status)) {
 		printf("could not open connection\n");