summaryrefslogtreecommitdiff
path: root/source4/torture
diff options
context:
space:
mode:
authorTim Prouty <tprouty@samba.org>2009-11-25 14:40:54 -0800
committerTim Prouty <tprouty@samba.org>2009-12-01 11:12:51 -0800
commit66bf780e6edac110b85d2a0d08d01274fe7417bd (patch)
tree01536dfe1d8ea8705eca731a106e6a9a510bf903 /source4/torture
parent2738e316746b078899dd30e07665d8e7b515581e (diff)
downloadsamba-66bf780e6edac110b85d2a0d08d01274fe7417bd.tar.gz
samba-66bf780e6edac110b85d2a0d08d01274fe7417bd.tar.bz2
samba-66bf780e6edac110b85d2a0d08d01274fe7417bd.zip
s4 torture: Change RAW-SFILEINFO-END-OF-FILE to check for share modes by default
Since the windows behavior appears to be a bug, only check for the windows-style share mode bug if target=<windows variant> is specified
Diffstat (limited to 'source4/torture')
-rw-r--r--source4/torture/raw/setfileinfo.c12
1 files changed, 5 insertions, 7 deletions
diff --git a/source4/torture/raw/setfileinfo.c b/source4/torture/raw/setfileinfo.c
index 0aa1f38c83..95fb9d7e06 100644
--- a/source4/torture/raw/setfileinfo.c
+++ b/source4/torture/raw/setfileinfo.c
@@ -772,17 +772,15 @@ torture_raw_sfileinfo_eof(struct torture_context *tctx, struct smbcli_state *cli
* Looks like a windows bug:
* http://lists.samba.org/archive/cifs-protocol/2009-November/001130.html
*/
- if (torture_setting_bool(tctx, "samba3", false) ||
- torture_setting_bool(tctx, "samba4", false) ||
- torture_setting_bool(tctx, "onefs", false)) {
+ if (TARGET_IS_W2K8(tctx) || TARGET_IS_WIN7(tctx)) {
+ /* It succeeds! This is just weird! */
+ torture_assert_ntstatus_equal_goto(tctx, status, NT_STATUS_OK, ret,
+ done, "Status should be OK");
+ } else {
torture_assert_ntstatus_equal_goto(tctx, status,
NT_STATUS_SHARING_VIOLATION, ret, done, "Status should be "
"SHARING_VIOLATION");
goto done;
- } else {
- /* It succeeds! This is just weird! */
- torture_assert_ntstatus_equal_goto(tctx, status, NT_STATUS_OK, ret,
- done, "Status should be OK");
}
/* Verify that the file was actually extended to 100. */