lib/param: Remove 'case insensitive filesystem'

We use the slightly confusing 'case sensitive = yes' option for the same behaviour.

This avoids adding even more confusing documentation for the ntvfs-only option.

Andrew Bartlett

1 files changed, 26 insertions, 1 deletions

diff --git a/source4/param/share_classic.c b/source4/param/share_classic.c
index 3442d6bd50..50b05f322e 100644
--- a/source4/param/share_classic.c
+++ b/source4/param/share_classic.c
@@ -229,7 +229,32 @@ static bool sclassic_bool_option(struct share_config *scfg, const char *opt_name
 	}
 
 	if (strcmp(opt_name, SHARE_CI_FILESYSTEM) == 0) {
-		return lpcfg_ci_filesystem(s, lpcfg_default_service(lp_ctx));
+		int case_sensitive = lpcfg_casesensitive(s, lpcfg_default_service(lp_ctx));
+		/*
+		 * Yes, this confusingly named option means Samba acts
+		 * case sensitive, so that the filesystem can act case
+		 * insensitive.
+		 *
+		 */
+		if (case_sensitive == Auto) {
+			/* Auto is for unix extensions and unix
+			 * clients, which we don't support here.
+			 * Samba needs to do the case changing,
+			 * because the filesystem is case
+			 * sensitive  */
+			return false;
+		} else if (case_sensitive) {
+			/* True means that Samba won't do anything to
+			 * change the case of incoming requests.
+			 * Essentially this means we trust the file
+			 * system to be case insensitive */
+			return true;
+		} else {
+			/* False means that Smaba needs to do the case
+			 * changing, because the filesystem is case
+			 * sensitive */
+			return false;
+		}
 	}
 
 	DEBUG(0,("request for unknown share bool option '%s'\n",