summaryrefslogtreecommitdiff
path: root/source4
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2008-12-01 14:40:51 -0800
committerJeremy Allison <jra@samba.org>2008-12-01 14:40:51 -0800
commit7c07be9cab2a39afec6e8a950e108215a6a72e98 (patch)
treefaea76a2dbf5fc4b0aec7635e543ca928dcbec19 /source4
parenta8595bf506ca43e7060d696f182982703885fa08 (diff)
downloadsamba-7c07be9cab2a39afec6e8a950e108215a6a72e98.tar.gz
samba-7c07be9cab2a39afec6e8a950e108215a6a72e98.tar.bz2
samba-7c07be9cab2a39afec6e8a950e108215a6a72e98.zip
s4:pvfs: return the correct error code for invalid names
metze
Diffstat (limited to 'source4')
-rw-r--r--source4/ntvfs/posix/pvfs_resolve.c21
1 files changed, 16 insertions, 5 deletions
diff --git a/source4/ntvfs/posix/pvfs_resolve.c b/source4/ntvfs/posix/pvfs_resolve.c
index 1e13474b9e..90ca251e1a 100644
--- a/source4/ntvfs/posix/pvfs_resolve.c
+++ b/source4/ntvfs/posix/pvfs_resolve.c
@@ -189,6 +189,9 @@ static NTSTATUS pvfs_case_search(struct pvfs_state *pvfs,
static NTSTATUS parse_stream_name(struct pvfs_filename *name, const char *s)
{
char *p;
+ if (s[1] == '\0') {
+ return NT_STATUS_OBJECT_NAME_INVALID;
+ }
name->stream_name = talloc_strdup(name, s+1);
if (name->stream_name == NULL) {
return NT_STATUS_NO_MEMORY;
@@ -199,9 +202,12 @@ static NTSTATUS parse_stream_name(struct pvfs_filename *name, const char *s)
strlen(name->stream_name));
return NT_STATUS_OK;
}
- if (strcasecmp_m(p, ":$DATA") != 0) {
+ if (p[1] == '\0') {
return NT_STATUS_OBJECT_NAME_INVALID;
}
+ if (strcasecmp_m(p, ":$DATA") != 0) {
+ return NT_STATUS_INVALID_PARAMETER;
+ }
*p = 0;
if (strcmp(name->stream_name, "") == 0) {
/*
@@ -266,12 +272,17 @@ static NTSTATUS pvfs_unix_path(struct pvfs_state *pvfs, const char *cifs_name,
while (*p) {
size_t c_size;
codepoint_t c = next_codepoint_convenience(lp_iconv_convenience(pvfs->ntvfs->ctx->lp_ctx), p, &c_size);
+
+ if (c <= 0x1F) {
+ return NT_STATUS_OBJECT_NAME_INVALID;
+ }
+
switch (c) {
case '\\':
if (name->has_wildcard) {
/* wildcards are only allowed in the last part
of a name */
- return NT_STATUS_ILLEGAL_CHARACTER;
+ return NT_STATUS_OBJECT_NAME_INVALID;
}
if (p > p_start && (p[1] == '\\' || p[1] == '\0')) {
/* see if it is definately a "\\" or
@@ -288,10 +299,10 @@ static NTSTATUS pvfs_unix_path(struct pvfs_state *pvfs, const char *cifs_name,
break;
case ':':
if (!(flags & PVFS_RESOLVE_STREAMS)) {
- return NT_STATUS_ILLEGAL_CHARACTER;
+ return NT_STATUS_OBJECT_NAME_INVALID;
}
if (name->has_wildcard) {
- return NT_STATUS_ILLEGAL_CHARACTER;
+ return NT_STATUS_OBJECT_NAME_INVALID;
}
status = parse_stream_name(name, p);
if (!NT_STATUS_IS_OK(status)) {
@@ -311,7 +322,7 @@ static NTSTATUS pvfs_unix_path(struct pvfs_state *pvfs, const char *cifs_name,
break;
case '/':
case '|':
- return NT_STATUS_ILLEGAL_CHARACTER;
+ return NT_STATUS_OBJECT_NAME_INVALID;
case '.':
/* see if it is definately a .. or
. component. If it is then fail here, and