diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2012-10-24 11:56:02 +1100 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2012-10-24 05:12:04 +0200 |
| commit | 8697acd4b08354fb4185b05da07f4399bda917bc (patch) | |
| tree | 099791212a9cf300ab2cd27f02c2c664b2c36907 /source4 | |
| parent | d5d0a454cef8c732235b554df89761d4dcd854ba (diff) | |
| download | samba-8697acd4b08354fb4185b05da07f4399bda917bc.tar.gz samba-8697acd4b08354fb4185b05da07f4399bda917bc.tar.bz2 samba-8697acd4b08354fb4185b05da07f4399bda917bc.zip | |
dsdb-cracknames: Always use talloc_zero()
Otherwise, we will return un-initialised values to the caller, which will
attempt to push them onto the wire.
Found by Greg Dickie <greg@justaguy.ca>.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Oct 24 05:12:04 CEST 2012 on sn-devel-104
Diffstat (limited to 'source4')
| -rw-r--r-- | source4/dsdb/samdb/cracknames.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source4/dsdb/samdb/cracknames.c b/source4/dsdb/samdb/cracknames.c index c366019c56..6ad802687e 100644 --- a/source4/dsdb/samdb/cracknames.c +++ b/source4/dsdb/samdb/cracknames.c @@ -1472,7 +1472,7 @@ WERROR dcesrv_drsuapi_CrackNamesByNameFormat(struct ldb_context *sam_ctx, TALLOC uint32_t i, count; WERROR status; - *ctr1 = talloc(mem_ctx, struct drsuapi_DsNameCtr1); + *ctr1 = talloc_zero(mem_ctx, struct drsuapi_DsNameCtr1); W_ERROR_HAVE_NO_MEMORY(*ctr1); count = req1->count; |