diff options
author | Stefan Metzmacher <metze@samba.org> | 2009-03-18 07:56:51 +0100 |
---|---|---|
committer | Stefan Metzmacher <metze@samba.org> | 2009-03-19 13:54:22 +0100 |
commit | 880fbc4e8cd67de73c4bcda94489eb1e1422a04b (patch) | |
tree | fb6459e1fed54287fc5f304d0acfcac8c485d5e7 /testprogs/blackbox | |
parent | 0dfdb7b911ed4fe013fc4a22a8c3a28620277a67 (diff) | |
download | samba-880fbc4e8cd67de73c4bcda94489eb1e1422a04b.tar.gz samba-880fbc4e8cd67de73c4bcda94489eb1e1422a04b.tar.bz2 samba-880fbc4e8cd67de73c4bcda94489eb1e1422a04b.zip |
s3:libsmb: fix smb signing for fragmented trans/trans2/nttrans requests
Before we send the secondary requests we need to remove the
old mid=>seqnum mapping and reset cli->mid and make the new
mid=>seqnum mapping "persistent".
The bug we had in cli_send_trans was this:
The first cli_send_smb() incremented cli->mid
and the secondary requests used the incremented mid,
but as cli->outbuf still had the correct mid,
we send the correct mid to the server. The real problem
was that the cli_send_smb() function stored the seqnum
under the wrong mid.
cli_send_nttrans() was totally broken and now follows the
same logic as cli_send_trans().
The good thing is that in practice the problem is unlikely to happen,
because max_xmit is large enough to avoid secondary requests.
metze
Diffstat (limited to 'testprogs/blackbox')
0 files changed, 0 insertions, 0 deletions